Skip to content

Get rid of deprecations - #285

Open
jacopotediosi wants to merge 4 commits into
kantlivelong:develfrom
jacopotediosi:get-rid-of-deprecations
Open

Get rid of deprecations#285
jacopotediosi wants to merge 4 commits into
kantlivelong:develfrom
jacopotediosi:get-rid-of-deprecations

Conversation

@jacopotediosi

Copy link
Copy Markdown

Hi, I'm an active contributor to OctoPrint core. I helped ship OctoPrint 2.0.0rc1 and I'm now helping plugins stay compatible with the new and upcoming OctoPrint releases, which is why you're receiving this PR.


Before submitting please make sure you have ticked all points on this checklist:

  • Your PR targets the devel branch.
  • Your PR was opened from a custom branch on your repository (no PRs from your version of master or devel please)
  • Your PR only contains relevant changes: no unrelated files, no dead code, ideally only one commit - rebase your PR if necessary!
  • Your changes follow the existing coding style.
  • You have tested your changes (please state how!)

Feel free to delete all this help text, then describe your PR further. You may use the template provided below to do that. The more details the better!


What does this PR do and why is it necessary?

This PR fixes the usage of some deprecated stuffs that were causing warnings in OctoPrint's logs.

In particular:

  • Enabled is_api_protected (ref)
  • Enabled is_template_autoescaped (ref).

A minor improvement is also applied: use is and is not for type comparisons.

How was it tested? How can it be tested by the reviewer?

I tested the installation on both OctoPrint 2.0.0rc1 and the latest stable release 1.11.7, and everything appears to work correctly.

Any background context you want to provide?

What are the relevant tickets if any?

Screenshots (if appropriate)

Further notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants