Skip to content

Guard release metadata and prepare Actions publishing - #27

Merged
kahwee merged 6 commits into
mainfrom
codex/release-publishing-audit-20261012
Oct 12, 2026
Merged

kahwee merged 6 commits into
mainfrom
codex/release-publishing-audit-20261012

Conversation

@kahwee

@kahwee kahwee commented Oct 12, 2026

Copy link
Copy Markdown
Owner

Adds tested release metadata guards to CI and an inactive npm OIDC workflow proposal. The runbook gives exact permissions and trust identity. No versions, tags, releases, registry bindings or workflow permissions were changed.

Validation: dependency-free guard tests, current metadata checks, Biome checks, YAML parsing and diff checks passed. Full verification stays in existing CI. Activation requires explicit access approval; the npm package is currently absent so ownership and first publication must be resolved separately.

@kahwee
kahwee marked this pull request as ready for review October 12, 2026 23:59
@kahwee
kahwee merged commit 2ba3010 into main Oct 12, 2026
1 check passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T00:04:30.878506Z 99b3862 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-13T00:03:51.515180Z 99b3862 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 99b3862adc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

permissions:
contents: read
actions: read
id-token: write

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Isolate OIDC from build and test steps

Once this proposal is activated, granting id-token: write to the whole job lets every subsequent command—including bun install lifecycle hooks and all repository/dependency code executed by bun run check—request an OIDC JWT through the runner environment; GitHub documents that this permission exposes the token-request URL and bearer token to the job (OIDC reference). A compromised dependency or malicious build/test script could therefore invoke npm publish before the guarded publish step and release arbitrary contents under this package. Run checkout/install/check/pack in an unprivileged job, pass the verified tarball to a minimal publishing job, and grant id-token: write only to that publishing job.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant