feat: add --sandbox-image-pull-policy flag for sandbox pods#4
Merged
Conversation
The compute driver now accepts a --sandbox-image-pull-policy flag that sets imagePullPolicy on both the supervisor init container and the agent container in sandbox pods. When omitted, the Kubernetes default applies (Always for :latest tags, IfNotPresent otherwise). This mirrors the upstream Rust driver's OPENSHELL_SANDBOX_IMAGE_PULL_POLICY env var and allows operators to avoid costly re-pulls of large sandbox images (e.g. 1.1GB base images) on every pod creation. Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImagePullPolicyfield to the driverConfigstruct--sandbox-image-pull-policyCLI flag (acceptsAlways,IfNotPresent,Never):latesttags)Motivation
Sandbox pods using
:latestimages (e.g.sandboxes/base:latestat 1.1GB) default toimagePullPolicy: Alwaysdue to Kubernetes default behavior. This causes ~90 second startup delays on every sandbox creation, even when the image is already cached on the node.The upstream Rust driver (
openshell-driver-kubernetes) already supports this via--sandbox-image-pull-policy/OPENSHELL_SANDBOX_IMAGE_PULL_POLICY. This PR brings parity to the OpenShift Go driver.Usage
Test plan
TestBuildSandboxSpec_ImagePullPolicy— verifies policy is set on both containersTestBuildSandboxSpec_ImagePullPolicy_Empty— verifies no field when config is emptygo test ./...)sandboxImagePullPolicy: IfNotPresent, verify sandbox pod spec🤖 Generated with Claude Code