Conversation
…switch real Settings → Goals & alerts gains a Send test button under the Notifications switch. It sends a notification shaped exactly like a reminder through the platform notifier, checks the permission first and says where to fix a block, and hedges after sending because an OS-level mute of the browser is invisible to the extension. Its id is reminder-test, which the worker's handlers already resolve to dismiss. The Notifications switch was read by nothing. The worker fire path, the page fallback and the Pomodoro completion now honour it via getSettings (field-wise defaults, fail-open on a rejection). The Notifier port gains permission() for all hosts. Four review rounds folded in. Fixes ENG-119
kYem
force-pushed
the
kes/eng-119-reminders-a-send-test-notification-button-so-people-can-see
branch
from
September 20, 2026 02:24
d8189f5 to
2c21721
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ENG-119
What
Send test under Settings → Goals & alerts → Notifications. It sends a notification with the exact shape a reminder has — same title, Done / Snooze buttons, sticky — so what you see is what a real one will look like. Before sending it asks the notifier for its permission and, on
denied, says where to fix it instead of sending. After sending it hedges: "Nothing appeared? Check your system's notification settings — the browser or app itself may be muted", because macOS can mute Chrome without Chrome knowing. The id isreminder-test, which the worker's click/button handlers already resolve to dismiss-and-clear, so Done / Snooze on the test just close it — no worker change.The Notifications switch now does something.
enableNotificationswas read by nothing; reminders and Pomodoro notified regardless. The worker fire path, the page fallback (fireDueReminderswhere there is no background host) and the Pomodoro completion now honour it. A failed settings read fails open — a storage hiccup must not silence reminders. Recurrence still advances andnotifiedis still stamped when the switch is off; only the OS notification is withheld, in-app toasts are unaffected.Port:
Notifier.permission()→'granted' | 'denied' | 'unknown'. Chrome →getPermissionLevel(); web →Notification.permission; Tauri →isPermissionGranted()(not-yet-granted reportsunknown, since the next notify prompts).Dropped from the ticket: the per-reminder Preview — the Settings button already shows the shape.
Review
The one thing no test can check: what the notification actually looks like on your screen. Load the branch build, Settings → search "test notification" → Send test.
Verification
e2e/test-notification.spec.ts: the built extension, Settings search → Send test → areminder-testentry inchrome.notifications.getAll()— greennotify()when the switch is off and still advance state; fail-open on an unreadable read; both notifier permission mappings; the row's off / blocked / sent / failed / filtered states; the section surfaces for a "test notification" search