SwiftContainer: add controller#824
Open
eshulman2 wants to merge 7 commits into
Open
Conversation
Scaffold the SwiftContainer controller using the controller generator: $ go run ./cmd/scaffold-controller -interactive=false -kind=SwiftContainer -gophercloud-client=NewObjectStorageV1 -gophercloud-module=github.com/gophercloud/gophercloud/v2/openstack/objectstorage/v1/containers -gophercloud-type=Container -openstack-json-object=container
Add the SwiftContainer API, generated clients, OpenStack client wrapper, controller wiring, status writer, and reconciliation logic. Swift containers are name-addressed, so the controller uses the container name as the ORC status ID and adds custom import handling for name-based imports.
Add unit coverage for Swift container import, adoption, creation, validation, and OpenStack client behavior. Add KUTTL suites for minimal and full creation, import success and failure, updates, and name validation, and enable Swift in the E2E environment.
Document SwiftContainer in the resource matrix and generated CRD reference, and add example manifests for create and import workflows.
winiciusallan
left a comment
winiciusallan
left a comment
Contributor
There was a problem hiding this comment.
Hey @eshulman2, thanks for the PR!
I did a round of review through the API and left other comments inline. Will take some time to look how CRUD operations are being performed and the tests :).
| // comma-separated list of account/container combinations. | ||
| // +kubebuilder:validation:MaxLength:=256 | ||
| // +optional | ||
| ContainerWrite *string `json:"containerWrite,omitempty"` |
Contributor
There was a problem hiding this comment.
Ditto for ContainerWrite
| } | ||
|
|
||
| // SwiftContainerResourceSpec contains the desired state of a Swift container. | ||
| type SwiftContainerResourceSpec struct { |
Contributor
There was a problem hiding this comment.
There are other fields that we could implement in the ResourceSpec, but I'm okay leaving as it is and add them later.
eshulman2
force-pushed
the
swiftcontainer-controller
branch
from
2fb1881 to
c85a5da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary