Repository navigation
Conversation
- Add JSpecify annotations to the template used to generate those files during builds. - This includes adding `@Nullable` to the `CharSequence` parameter in each relevant `CharBuffer.append` overload. - Make our hard-coded `ByteBuffer.java` match the actual generated output. - Add hard-coded copies of the other `*Buffer.java` classes. - Add a test that ensures that we update those copies for new changes. This should all have no practical impact on users of checkers that are lenient with unannotated code, but it could help users of strict checkers that call `equals` or `append` on `*Buffer` classes (besides `ByteBuffer.equals`, which we already had covered).
|
The existing and new hard-coded files aren't necessary for tools that actually run this repo's full build process or even use a lighter-weight process that at least uses The rest of this PR should be useful more generally. |
msridhar
left a comment
There was a problem hiding this comment.
I only reviewed the template; it looks good to me
|
Thanks, I'll take it :) I just set Opus 5.5 (medium) to work on looking for potential traps in the
|
@Nullableto theCharSequenceparameter in each relevantCharBuffer.appendoverload.ByteBuffer.javamatch the actual generated output.*Buffer.javaclasses.This should all have no practical impact on users of checkers that are lenient with unannotated code, but it could help users of strict checkers that call
equalsorappendon*Bufferclasses (besidesByteBuffer.equals, which we already had covered).