Repository navigation
Update whatwg-url to v17 - #49
Merged
Merged
Conversation
Align the Node.js engine requirement and CI matrix with whatwg-url. Co-authored-by: codex <codex@openai.com>
scttcper
marked this pull request as ready for review
September 26, 2026 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update whatwg-url to ^17.1.2 so data-urls and jsdom can share one copy of whatwg-url instead of installing separate versions. The jsdom dependency tree we investigated currently has:
A fresh consumer install resolves both dependencies to one whatwg-url package after this change.
This drops Node 20 support and raises the Node 22 minimum to 22.14.0, matching whatwg-url’s engine requirement. Update the CI matrix accordingly.