fix(herdr): update repo owner to herdrdev after transfer - #150
Closed
jsburckhardt wants to merge 1 commit into
Closed
fix(herdr): update repo owner to herdrdev after transfer#150jsburckhardt wants to merge 1 commit into
jsburckhardt wants to merge 1 commit into
Conversation
The upstream herdr repo was transferred from ogulcancelik/herdr to herdrdev/herdr. The GitHub API responds with a 301 redirect for the old path, and install.sh used 'curl -s' without -L, so get_latest_version returned an empty tag and the install failed with 'Failed to resolve latest version from GitHub API.'. - Point REPO_OWNER at herdrdev - Add -L to the latest-version curl call so future redirects don't break the install - Update descriptions and README links Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The upstream
herdrrepo was transferred fromogulcancelik/herdr→herdrdev/herdr. GitHub's API returns301 Moved Permanentlyfor the old path, andinstall.shusedcurl -s(no-L), soget_latest_versionreturned empty and the feature failed to install:CI didn't catch this because
test.yamlonly runs on changes tosrc/**/test/**, so main-branch builds haven't re-exercised herdr's install path since the transfer.Fix
REPO_OWNERatherdrdev-Lto theget_latest_versioncurl so future redirects don't silently breakVerification