1.2: backport minor fixes and Rails 8.1 appraisal - #484
Merged
Conversation
Runs a Lint wrapped app through Rack::Handler::Servlet (both DefaultEnv and ServletEnv modes) and writes the response back through the servlet response path, so env construction, rack.input behavior and body close handling are validated against the loaded Rack version's SPEC. Also fixes the Rack 2.x arm's rack.version value to be Rack::VERSION (the protocol version Array the Rack 2 SPEC and Lint expect) (cherry picked from commit 84f2d49)
The newline-splitting header write path called chomp! on each yielded value - a frozen String ending in a newline raised FrozenError, and non-frozen app-owned header values were being modified in place. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 6e843d6)
chadlwilson
force-pushed
the
1.2-backport-fixes
branch
from
September 9, 2026 07:37
c83dcbf to
b5627bb
Compare
I could swear I thought Rails 8.1 didn't support Rack 2.2 when it was released... (cherry picked from commit d10e3c3)
chadlwilson
force-pushed
the
1.2-backport-fixes
branch
from
September 9, 2026 07:42
b5627bb to
9e5ee83
Compare
chadlwilson
marked this pull request as ready for review
September 9, 2026 07:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports from 1.3 branch