[fix] X509 store issuer lookup with duplicate subject DNs - #379
Merged
Merged
Conversation
certificate implementations already cache the code
The local certificate store preserves insertion order rather than OpenSSL's subject index ordering. Continue scanning after nonmatching entries so rotated CAs with the same subject can be considered during verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix certificate-chain verification when multiple CA certificates share the same subject DN, such as during CA rotation.
The store now continues scanning all matching certificate entries instead of assuming same-subject entries are contiguous. This allows verification to find the issuer whose key and signature actually match.
Also tighten certificate and CRL object matching to use full encoded-object equality, avoiding collisions between distinct objects from the same issuer/subject.