miscellaneous 72 stable prod fixes (Postgres)#1206
Conversation
|
@JesseChavez Do you have any idea on the massive regression on postgresql tests? I do not think it has anything to do with your PR but we seem to no longer be closing active connections (at least in some case). I mean maybe we are raising on some type binds but not cleaning stuff up but obviously not running a job since september on 72-stable is the most likely culprit. |
| if ( value == context.nil ) { | ||
| statement.setNull(index, type); | ||
| // statement.setNull(index, type); | ||
| statement.setObject(index, null); |
There was a problem hiding this comment.
have you considered only fixing this for PG, if that is an actual concern?
would be nice to have a failing test case to see if this isn't hiding another issue, would be surprised if a mature JDBC driver would not handle setNull properly
| // } | ||
| // } | ||
|
|
||
| statement.setObject(index, value.asString().toString(), Types.OTHER); |
There was a problem hiding this comment.
seems risky to change this, not sure if the included test case related to this?
|
I've started working with @skunkworker to merge in a bunch of LLM-created changes to bring us more in parity with the 7.2 and 8.1 Rails adapters, with a specific focus on PG. Please coordinate with him and try to figure out which changes make sense to pull from here. I know we've lagged behind keeping up the PG adapter, but with the knowledge you both have of PG behavior and assistance from some tooling I think we can rapidly catch up. |
|
Hi @headius we have branch with all the changes and fixes to support Rails 8.0 for postgres. At the moment we are working fixes for sqlserver. Are you guys in interested on this work ? |
Absolutely! @skunkworker also submitted an attempt at auto generating 8.1 support but there's a number of concerns about duplicated code and tests. Anything that moves us further away from calling reusing Rails core code will just be harder to maintain long-term. Let's see what you've got and try to combine all of our efforts to get updated drivers out. |
|
Thanks the PR will be ready for tomorrow Australian Time |
4 participants
Hi JRuby team
Here is some miscellaneous fixes the we found and fixed in my fork
Notes I only cherry-picked Postgres fixes and I have not tested in SQLite and MySQL
hope casting the binds is not affecting MySQL or SQLite