Support JSON feed version 1.1 by Kiwow · Pull Request #247 · jpmonette/feed

Kiwow · 2026-06-05T12:12:08Z

Closes #246

Thanks for your hard work maintaining this! I had a go at implementing support for the JSON feed version 1.1 spec.

I've added:

support for multiple authors for both feeds and items. In the case that a single author is provided, we convert it into a 1-item array and use it in the "authors" field, because the spec has deprecated "author" and recommends only using the array field.
support for the "language" field for both feeds and items
declaration of the 1.1 feed version
tests that fail without this PR and succeed with it
workaround for multiple feed authors for RSS and Atom - to implement multiple feed authors for JSON feed, I changed the type of FeedOptions.author to include an array of authors. When multiple feed authors are provided, I've made it so that only the first one is used in case of RSS and Atom. This could be addressed in the future, although I'm not sure about how/if RSS and Atom support multiple feed authors

I'm not sure if provided contributors should be merged into the authors array, but I haven't done so yet. In the (current) version 1 implementation, contributors are ignored for JSON feed as well. If it makes sense to you to merge contributors in, I don't have a problem with adding that bit.

jpmonette · 2026-06-26T20:35:01Z

-    if (options.author.avatar) {
-      feed.author.avatar = options.author.avatar;
-    }
+    feed.authors = toArray(options.author).map((author) => ({


Suggested change

feed.authors = toArray(options.author).map((author) => ({

feed.authors = (Array.isArray(options.author) ? options.author : [options.author]).map((author) => ({

I've switched the implementation to use both a author and authors property for the feed options, but I've essentially made this change, it's just checking for the different properties instead of checking if one is an array

jpmonette · 2026-06-26T20:36:25Z

+  if (options.author && Array.isArray(options.author)) {
+    options.author = options.author[0];
+  }


I'm skeptical this is valid - can you provide a reference?

After researching this, multiple authors in RSS is a huge mess. It took me a while to notice that this library only renders feed author in the case of podcasts. Because of that, I think it's enough to fallback to the first authors in case multiple are specified.

jpmonette · 2026-06-26T20:39:20Z

    if (item.author) {
-      let author: Author | Author[] = item.author;
-      if (author instanceof Array) {
-        // json feed only supports 1 author per post
-        author = author[0];
-      }
-      feedItem.author = {};
-      if (author.name) {
-        feedItem.author.name = author.name;
-      }
-      if (author.link) {
-        feedItem.author.url = author.link;
-      }
-      if (author.avatar) {
-        feedItem.author.avatar = author.avatar;
-      }
+      feedItem.authors = item.author.map((author) => ({
+        name: author.name,
+        url: author.link,
+        avatar: author.avatar,
+      }));


Could you preserve existing behavior if 1.0 is used, to be backward compatible? Same for the one at the top-level.

I think I've done this. item.author is already an array and I've updated my changes so that feed.author is always a single author. For multiple authors, I've added an FeedOptions.authors property like you suggested in a comment below. So if you decide to merge this it should be able to come out as a minor, because the library's API is the same as before and behavior is the same for the same inputs.

Unless I'm misunderstanding and you mean we should have options for generating both a JSON Feed 1.0 and 1.1. In that sense, my changes aren't backwards compatible, because they always create a 1.1 feed. I assumed readers generally support 1.1 since it's almost 6 years old now, but I might be wrong.

jpmonette · 2026-06-26T20:41:21Z

  if (options.author) {
-    base.feed.author = formatAuthor(options.author);
+    base.feed.author = formatAuthor(Array.isArray(options.author) ? options.author[0] : options.author);


I'd expect this change to be covered in tests?

You're right, sorry. I realized Atom supports multiple authors so that's what I implemented instead, and I added a test to verify that my implementation works. Let me know what you think

jpmonette · 2026-06-26T20:42:45Z

  category?: string;

-  author?: Author;
+  author?: Author | Author[];


Suggested change

author?: Author | Author[];

/**

* @deprecated Use authors instead. This will be removed in next major.

*/

author?: Author;

authors?: Author[];

This is way nicer than what I did originally. I changed the deprecation comment a bit, but otherwise I've done this

jpmonette · 2026-06-26T20:43:30Z

+export const createSampleFeed = ({
+  authors,
+  itemAuthors,
+}: Partial<{ authors: FeedOptions["author"]; itemAuthors: Item["author"] }> = {}) => {


Can we restore original APi?

As noted in a previous comment, I ended up keeping FeedOptions.author the same and added a FeedOptions.authors property. If I'm understanding correctly, that keeps the library API the same.

I hope it's okay that I added some optional helper arguments to the createSampleFeed function to make some tests nicer, which is what is present in this diff. Those arguments now reflect FeedOptions["authors"]

jpmonette · 2026-06-26T20:47:34Z

  id?: string;
  link: string;
  date: Date;
+  language?: string;


Atom seems to support this as well, so please make sure it's added to the entries.

Could you also do a loose validation that it is ISO 639-1? Combination of lowercase + /^[a-z]{2}(-[a-z]{2})?$/.test(code).

Good point, thanks. I added a validateLanguageCode utility to be used when adding language to JSON feeds and the xml:lang attribute in Atom.

jpmonette · 2026-06-26T20:51:57Z

@Kiwow Thanks for the contribution - please address the review.

Conflicts: src/__tests__/__snapshots__/json.spec.ts.snap src/json.ts

Kiwow · 2026-07-14T21:28:21Z

@Kiwow Thanks for the contribution - please address the review.

Thanks for the review @jpmonette! Sorry about the time it took me to respond. I've found some time for open source again, so I should be more responsive now.

I changed the PR quite a bit based on your feedback. Please let me know what you think / if I misunderstood anything. There's also a few seemingly unrelated changes caused by the move to vitest and biome.

P.S. Don't be fooled by GitHub saying I added the new commits five days ago. I just pushed them

Kiwow added 3 commits June 5, 2026 13:49

Support multiple feed/item authors for JSON feed

4c8517d

Support "language" field for JSON feed/item

9d5afd8

Workaround multiple feed authors for RSS and Atom

b1bc05d

Kiwow mentioned this pull request Jun 5, 2026

feat: provide rss, atom and json feeds for the blog npmx-dev/npmx.dev#2562

Open

9 tasks

ghostdevv reviewed Jun 5, 2026

View reviewed changes

Comment thread src/atom1.ts Outdated

Replace instanceof Array by Array.isArray

73145b0

jpmonette reviewed Jun 26, 2026

View reviewed changes

Comment thread src/utils.ts

jpmonette reviewed Jun 26, 2026

View reviewed changes

Kiwow added 6 commits July 9, 2026 18:01

Merge remote-tracking branch 'origin/main' into json-feed-1.1

98b0867

Conflicts: src/__tests__/__snapshots__/json.spec.ts.snap src/json.ts

Add language support for Atom

366cbfc

Add multiple authors to Atom

39f2d46

Update JSON feed implementation

fd37775

Add fallback for RSS multiple authors

1736b92

Add forgotten validation to JSON feed language

c29fda1

Kiwow requested a review from jpmonette July 14, 2026 21:34

	feed.authors = toArray(options.author).map((author) => ({
	feed.authors = (Array.isArray(options.author) ? options.author : [options.author]).map((author) => ({

Uh oh!

Conversation

Kiwow commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jpmonette Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jpmonette commented Jun 26, 2026

Uh oh!

Kiwow commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Kiwow commented Jun 5, 2026 •

edited

Loading

jpmonette Jun 26, 2026 •

edited

Loading

Kiwow commented Jul 14, 2026 •

edited

Loading