Repository navigation
docs: clarify concat and document string and boolean types - #3745
Conversation
|
Thanks for your ongoing efforts to improve mathjs documentation.
|
|
These updates were prepared with AI assistance. I have also reviewed the documentation myself, and I have not found any further issues in it. |
gwhitney
left a comment
There was a problem hiding this comment.
OK, this documentation is really starting to shape up! Thanks so much. Nice job on the HISTORY section.
Are you aware of any further items in issue #3401 that this PR now does not address? I am not saying you have to extend this PR any further -- you've done nice work -- but we just need to be aware of the status of #3401 when this is eventually merged. Thanks.
|
Thanks for all of your changes; I will do the final checks for merging when you take this PR out of draft status (i.e., hit the "ready for review" button above. |
|
The documentation changes are ready for review. The broken add/max examples in #3401 were already corrected in de7865c. This PR adds the String and Boolean pages, clarifies concat, lists it in the String reference category, and documents other functions that accept strings. The remaining question is whether to introduce a dedicated concatenation operator. This PR does not implement one; I understand from Jos's reply that concat(a, b) remains an acceptable solution. I am interested in continuing to contribute to mathjs, including the usolve validation and benchmarking work discussed in #2333. |
|
OK, I opened discussion #3762 for any future conversation about string concatenation operators (you are right, there are no current plans in that direction). Will prepare this PR for merge, and then close #3401. You are welcome to continue contributing to the usolve situation or other open items, thank you. |
Summary
Addresses the documentation portions of #3401. The proposed concatenation operator remains a separate design question. Prepared with AI assistance.
Validation
Windows, Node.js 24.15.0: the latest local full test:all run on 2026-11-04 passed (6,671 source tests, 22 pending; 36 generated-code tests; 298 Node tests; TypeScript phase completed). Lint and build:docs passed. Additional checks covered 46 documentation expressions, 58 local links and 3 documentation category tests. Existing warnings included outdated Browserslist data and JSDoc warnings.
Earlier runs encountered the Node CLI output-order failure documented in the PR history; it was not conclusively attributed. The later local full run passed. The current head d0bd6db, which includes the review revisions and the maintainer's develop merge, has successful build-and-test, Node 20/22/24, lint, coverage and browser checks. Browser tests were run in CI, not locally.