Repository navigation
docs: show the physical constant values that math.js uses - #3740
Merged
Merged
Conversation
Collaborator
|
As with #3741, this would be more rapidly/eagerly accepted if it included, or came in conjunction with another PR that included, testing all of the values in this table against the code as part of |
Contributor
Author
|
Thanks, good idea. Added in f339b64:
|
Collaborator
|
It seems (?) the new test fails in browser testing... please take a look when you have a chance, thanks. |
Contributor
Author
|
My mistake, sorry: the test used
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table of physical constants in
docs/datatypes/units.mdshows old values that are not the ones math.js returns. For example:Many of the old values also have their uncertainty digits glued to the number (CODATA 2010 gives G = 6.67384(80)e-11, the table showed
6.6738480e-11).This PR puts the values from
src/type/unit/physicalConstants.jsinto the table, so the docs match the code (42 rows). Only the value column changes. The commented-outjosephsonrow is left as it is.AI disclosure: written with an AI coding assistant; the values were copied from
src/type/unit/physicalConstants.jsand checked against it.