Skip to content

docs: clarify row layout for two-dimensional matrices - #3700

Merged
gwhitney merged 3 commits into
josdejong:developfrom
Hugohong258:docs/clarify-matrix-rows
Nov 5, 2026
Merged

gwhitney merged 3 commits into
josdejong:developfrom
Hugohong258:docs/clarify-matrix-rows

Conversation

@Hugohong258

@Hugohong258 Hugohong258 commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Correct the reversed row and column terms in the two-dimensional matrix layout explanation. The additional rewrite and multiply API documentation changes have been removed after review.

Closes #2618.

Validation: checked that size([[0, 1, 2], [3, 4, 5]]) returns [2, 3]. git diff --check passed. Documentation only; the complete test suite was not rerun for this revision.

@gwhitney

gwhitney commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Thanks for another doc PR, I appreciate the attention you are giving to them.

I agree that the words row and column were reversed in the first paragraph you rewrote in this PR. But I am unclear why there are any changes besides swapping those words to correct them? Please describe the benefits of your other edits. Thanks.

@Hugohong258

Copy link
Copy Markdown
Contributor Author

The extra explanation was intended to connect the array representation to matrix multiplication, but it is unnecessary for correcting the reversed terms here. I have removed those additions and restored the original multiply documentation. The remaining change corrects row and column in the matrices guide (d7f02f5).

@gwhitney

gwhitney commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Since this change is now so tiny, I am not going to add a HISTORY entry for it, thanks for understanding (and thanks for finally addressing this). Merging.

@gwhitney
gwhitney merged commit 3afc3e5 into josdejong:develop Nov 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make documentation clearer that the top-level elements of a 2D rectangular array are considered **rows** of matrices.

2 participants