Repository navigation
Conversation
NewEmailFromReader split To and Cc on every comma. "Doe, John" became two fields. A comma in a comment did the same. A comma between addresses still splits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewEmailFromReadersplitTo,Cc,Bcc, andReply-Toon every comma."Doe, John" <john@example.com>came back as"DoeandJohn" <john@example.com>.(Doe, John) <john@example.com>was split the same way. A comma between addresses still splits.Jordan Wright <jmwright798@gmail.com>, also@example.comis still two addresses.ExampleGmailandExampleAttachwere renamed toExample_gmailandExample_attach. Those names referred to functions that are not in the package, sogo testdid not compile.Test plan
Tofields before the change and two aftergo test -count=1 .