Repository navigation
Doing groups for attempt-based rounds - #133
Merged
Merged
Conversation
aasalobrena
changed the title
Comment on lines
+130
to
+134
| /* Older versions assigned competitors to attempt activities directly. | ||
| Now we assign them to a group activity inside each attempt activity. | ||
| Competitions assigned the old way still have those assignments, | ||
| so we remove them here to avoid assigning everyone twice. */ | ||
| wcif = removeAttemptAssignments(wcif, round.id); |
Owner
There was a problem hiding this comment.
Competitions with existing attempt assignments are now going to show that groups and assignments are missing for mbld/fm. That's not a big issue, since we show a clear indicator and the user will just hit the button to create and assign again. However, the competitors would still have the old assignments, so they would be assigned to both 333fm-r1-a1 and 333fm-r1-a1-g1.
I added this code such that we remove the attempt assignments, before we create the new ones, and we avoid the duplicate assignments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second part of #131.
A straightforward change: