Repository navigation
Name libxml2 for Windows - #3
Merged
Merged
Conversation
jolt reads only the running platform's :jolt/native key, so without a :windows entry libxml2 was never found there even with the DLL on PATH. These are the MSYS2 names, current and older, and the official build's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jolt only reads the running platform's
:jolt/nativekey, so with no:windowsentry libxml2 was never found on Windows, even with the DLL onPATH. This addslibxml2-16.dll(MSYS2's current build),libxml2-2.dll(its older one) andlibxml2.dll.Found while getting newsroom's CI running on Windows, where MSYS2 installs
libxml2-16.dll. The tests pass on macOS.