Skip to content

Accept the JVM's class name for a host ByteArrayInputStream #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yogthos merged 1 commit into from
Oct 28, 2026
Merged

Accept the JVM's class name for a host ByteArrayInputStream #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/jolt/http/stream_shim_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@
(let [host-streams? @#'jolt.http.platform/host-byte-streams?]
(if host-streams?
(testing "jolt models them, so no ctor override and these are jolt's own"
(is (= "class java.io.InputStream" (str (type (ByteArrayInputStream. (byte-array 1))))))
;; jolt before 0.8.24 named the host stream by its interface; later
;; versions name the class itself, as the JVM does. Either is jolt's own.
(is (contains? #{"class java.io.InputStream" "class java.io.ByteArrayInputStream"}
(str (type (ByteArrayInputStream. (byte-array 1))))))
(is (not= "class :object" (str (type (ByteArrayOutputStream.))))))
(testing "jolt cannot answer the surface, so the shim stands in"
(is (= "class :object" (str (type (ByteArrayInputStream. (byte-array 1))))))))))
Loading