Skip to content

Makefile: auto-run composer install before phpcs #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmnote merged 1 commit into from
Sep 6, 2026
Merged

Makefile: auto-run composer install before phpcs #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,11 @@ checks: test phpcs ## Everything CI runs before merging (needs `composer install
test: ## Run the pure-PHP test suites
php tests/QuotesTest.php

phpcs: ## parallel-lint + minus-x + phpcs against the MediaWiki coding standard
phpcs: vendor/autoload.php ## parallel-lint + minus-x + phpcs against the MediaWiki coding standard
composer test

vendor/autoload.php: composer.json
composer install --no-progress

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Refresh the ignored lock when requirements change

When an existing checkout already has the ignored composer.lock and a later revision changes composer.json (for example, bumps one of these exact dev-tool versions), this recipe runs but fails or installs stale versions because Composer still prioritizes the old lock. Composer's install documentation says it reads composer.lock when present and only falls back to composer.json when absent; a newly required package therefore produces “not present in the lock file” instead of making phpcs usable. Regenerate/remove the untracked lock or use the appropriate update operation when composer.json is newer.

Useful? React with 👍 / 👎.


mathjax: ## Pin the local MathJax submodule + CDN major version, e.g. `make mathjax MATHJAX_VERSION_LOCAL=4.1.3 MATHJAX_VERSION_CDN=4`
hack/mathjax.sh $(MATHJAX_VERSION_LOCAL) $(MATHJAX_VERSION_CDN)
Loading