Skip to content

Harden routing heuristics, add dot_clean timeout, expand tests, add CI - #1

Merged
jitdor merged 3 commits into
mainfrom
ccr-50f79bab-c9ld9h
Sep 29, 2026
Merged

jitdor merged 3 commits into
mainfrom
ccr-50f79bab-c9ld9h

Conversation

@jitdor

@jitdor jitdor commented Sep 29, 2026

Copy link
Copy Markdown
Owner
  • Match aliases as whole words after normalizing separators; drop padded aliases
  • Require a same-stem (or multi-track) CUE to route a BIN to PlayStation
  • Time out hung dot_clean and drain its output concurrently
  • Add tests for ImportExecutor, MetadataCleaner symlinks, m3u/CUE resolution
  • Add macOS GitHub Actions workflow running swift build/test

Co-Authored-By: Claude Sonnet 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01Apys6XL8BAS3tGcbfB2hYu

- Match aliases as whole words after normalizing separators; drop padded aliases
- Require a same-stem (or multi-track) CUE to route a BIN to PlayStation
- Time out hung dot_clean and drain its output concurrently
- Add tests for ImportExecutor, MetadataCleaner symlinks, m3u/CUE resolution
- Add macOS GitHub Actions workflow running swift build/test

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Apys6XL8BAS3tGcbfB2hYu
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Apys6XL8BAS3tGcbfB2hYu

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e2ba58e3e2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

_ = drained.wait(timeout: .now() + 2)
throw DotCleanError.timedOut(seconds: timeout)
}
drained.wait()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Bound output draining after the parent exits

When the executable exits after spawning a subprocess that inherits stdout or stderr, finished is signaled before the pipe reaches EOF, so this unconditional wait can block indefinitely and bypass the configured timeout. For example, a script containing sleep 30 &; exit 0 makes clean wait about 30 seconds even with a sub-second timeout, leaving the eject UI stuck; apply a deadline to the drain phase as well and close or otherwise release the pipe on expiry.

Useful? React with 👍 / 👎.

@jitdor
jitdor merged commit 644a00c into main Sep 29, 2026
1 check passed
@jitdor
jitdor deleted the ccr-50f79bab-c9ld9h branch September 29, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants