Skip to content

refactor: honor suppression in the shared role-analysis path - #13

Merged
jier merged 3 commits into
mainfrom
feature/one-analysis-path
Sep 13, 2026
Merged

jier merged 3 commits into
mainfrom
feature/one-analysis-path

Conversation

@jier

@jier jier commented Sep 13, 2026

Copy link
Copy Markdown
Owner
  • analyze_role() gained apply_suppressions and now filters in one place, returning RoleAnalysis.suppressed.
  • Single-role orchestrator reads the already-filtered result (dropped its inline block).
  • scan collection and document role --collection now pass apply_suppressions=True → all three paths honor suppression identically (previously a suppressed finding still showed in scan/collection).
  • 2 new parity tests (unit analyze_role + end-to-end scan collection).
  • Single-role keeps role_path as base (correct for --role .), and I recorded the one residual honestly: absolute --role /abs/path single-role still resolves from the role dir, not cwd — a small follow-up, not a regression.

Change set: role_analysis.py, role_orchestrator.py, document_collection.py, scan/collection.py, CLAIMS.md, + new tests/suppression/test_analysis_path_parity.py.add RAG and web app Kusto query examples
…ecorded the one residual honestly: absolute --role /abs/path single-role still resolves from the role dir, not cwd — a small follow-up, not a regression.
@jier
jier merged commit 3763ea7 into main Sep 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant