conditional_tasks → graph-derived (same pass as conditional_decision_… - #12
Merged
Merged
Conversation
…points): the duplicate flattened-task scan is gone, so they can't drift like task_includes did.
error_handlers fixed: was dead (scanned flattened tasks for a rescue/always key that never exists → always 0). Now the graph detects block/rescue/always and sets error_handling on the node; error_handlers counts it. Unit-tested (rescue block → 1); stays 0 for roles genuinely without rescue (CIS, openstack).
Reachability is now a complete, honest partition (the candidate-10 finding): static_reachable + dynamically_reachable + unreachable == task_files. openstack now reads 2 + 13 + 5 = 20 (previously "static 2 / orphan 5" silently hid the 13 dynamic-gated files). orphan_task_files renamed unreachable_task_files, with a README note explaining the tiers (and that files behind an unresolved dynamic boundary stay "unreachable" — the graph still won't guess {{ pkg_mgr }}.yml).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
error_handlers fixed: was dead (scanned flattened tasks for a rescue/always key that never exists → always 0). Now the graph detects block/rescue/always and sets error_handling on the node; error_handlers counts it. Unit-tested (rescue block → 1); stays 0 for roles genuinely without rescue (CIS, openstack).
Reachability is now a complete, honest partition (the candidate-10 finding): static_reachable + dynamically_reachable + unreachable == task_files. openstack now reads 2 + 13 + 5 = 20 (previously "static 2 / orphan 5" silently hid the 13 dynamic-gated files). orphan_task_files renamed unreachable_task_files, with a README note explaining the tiers (and that files behind an unresolved dynamic boundary stay "unreachable" — the graph still won't guess {{ pkg_mgr }}.yml).