fix: only evaluate simple text block escape sequences#861
Merged
jtkiesel merged 1 commit intojhipster:mainfrom Apr 27, 2026
Merged
fix: only evaluate simple text block escape sequences#861jtkiesel merged 1 commit intojhipster:mainfrom
jtkiesel merged 1 commit intojhipster:mainfrom
Conversation
jtkiesel
force-pushed
the
fix/text-block-escape-evaluation
branch
from
a201d7f to
393942c
Compare
jtkiesel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed with this PR:
No longer evaluate unicode escape sequences in text blocks. Also no longer evaluate octal escape sequences,
\b, and\fin embedded language text blocks, in favor of only evaluating "simple" escape sequences working with whitespace, quotes, and\\. Finally, fixes some other bugs with embedded language text blocks, such as properly escaping sequences of >3"(for example instead of""""being improperly escaped as\"""", it will now be escaped as""\""), and properly avoiding trailing unescaped"from bleeding into the closing""".