Skip to content

Enforce governance filtering and install disambiguation for AI Catalog skills - #81

Closed
goldron1 wants to merge 2 commits into
mainfrom
ai-catalog-governance-filtering
Closed

goldron1 wants to merge 2 commits into
mainfrom
ai-catalog-governance-filtering

Conversation

@goldron1

@goldron1 goldron1 commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Always pass --allowed-only on --list-skills / --list-skill-versions — no code path omits it, and requests to see blocked/disallowed results are refused rather than served by re-running without the flag.
  • Never default to latest or the first repository on jf skills install; resolve version then repo from a single --list-skill-versions call.
  • Matches the equivalent behavior already shipped in the Cursor plugin's jfrog-ai-catalog skill.
  • Fix-up commit: Copilot Chat has no native arrow-key single-choice picker (unlike Claude Code's AskUserQuestion or Cursor's picker — see jfrog-init/references/how-to-ask-user.md, which never lists VS Code/Copilot Chat as having one). The first pass of this PR incorrectly claimed "VS Code's Quick Pick UI" as an available picker; corrected so version/repo choices always use the Markdown table + plain-language question fallback on this harness.

Test plan

  • Diffed the updated discovering-skills.md / installing-skills.md against the Cursor plugin's versions to confirm parity (only the harness-specific Choice UI section intentionally differs, since Copilot Chat has no native picker).
  • Manually walk through list/install flows with a project that has more than one skills repo and confirm version-then-repo resolution via the table/question fallback, without assuming latest/first.

🤖 Generated with Claude Code

… for AI Catalog skills

Match the Cursor plugin's jfrog-ai-catalog behavior: always pass --allowed-only on --list-skills/--list-skill-versions with no bypass path, refuse requests to see blocked/disallowed results, and never default to latest or the first repo when installing. Resolve version then repo from a single --list-skill-versions call, using the native picker UI when available.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@goldron1
goldron1 requested a review from a team as a code owner September 16, 2026 10:59
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

…e fallback

how-to-ask-user.md's harness table never listed VS Code/Copilot Chat as having a native single-choice prompt tool -- skills here are chat-turn instructions with no access to VS Code's showQuickPick API. Remove the unverified 'VS Code's Quick Pick UI' claim.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants