Repository navigation
Conversation
…uild metadata Helm pushes chart X.Y.Z+meta under the OCI tag X.Y.Z_meta. The tests check that jf helm push collects build info for such a chart: the module id keeps the real version, the artifacts and the build properties are in the '_' folder. Push errors are never skipped for these tests. Needs the jfrog-cli-artifactory fix from jfrog/jfrog-cli-artifactory#581.
Contributor
Author
|
@coderabbitai review |
… cleanup order Check build.number as well as build.name, delete the test builds, restore the working directory before removing the chart directory in the coexistence test, and make loginHelmRegistryOrSkip return nothing (it never returned false).
bhanurp
requested review from
a team,
agrasth,
fluxxBot,
itsmeleela,
naveenku-jfrog and
reshmifrog
and removed request for
a team
November 2, 2026 09:57
itsmeleela
reviewed
Nov 2, 2026
udaykb2
approved these changes
Nov 2, 2026
itsmeleela
approved these changes
Nov 3, 2026
…er build metadata fix jfrog-cli-artifactory main now has the fix (jfrog/jfrog-cli-artifactory#584), so TestHelmPushWithSemVerBuildMetadata can pass.
Contributor
Contributor
Author
|
closing this since #3752 is already merged |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E2E tests for RTECO-2742:
jf helm pushbuild-info collection for chart versions with SemVer build metadata (+). Helm pushesX.Y.Z+metaunder the OCI tagX.Y.Z_meta, and the build-info lookup used the+form.go.modnow points tojfrog-cli-artifactory30c80a7, which contains the fix (jfrog/jfrog-cli-artifactory#584, merged). These tests run against that version.Tests
TestHelmPushWithSemVerBuildMetadata(cases: no subpath1.2.3+abc1234, subpath103.287.0+0b2041e) checks:jf helm pushexits 0 and build info is published.chart:1.2.3+abc1234._folder,chart/1.2.3_abc1234/.build.nameandbuild.numberare set on the_folder'smanifest.json.A failed push is never skipped in these tests, so the regression cannot pass as a skipped test. The usual skips for a missing repository or an unusable registry login still apply.
runHelmSubpathPushTestnow uses a shared helper,pushHelmChartAndGetBuildInfo. The helper and the coexistence test restore the working directory before they remove the chart directory, which Windows requires. The new tests delete their builds.Verified on a real server
A
jfbinary built from this branch (the pinnedgo.mod, noreplace) against a temporary Helm OCI repo, chart1.2.3+abc1234:jfbefore the fixjffrom this branchno OCI artifacts found for chart semverchart:1.2.3+abc1234)semverchart:1.2.3+abc1234, artifacts undersemverchart/1.2.3_abc1234/Logs and a reproduce script are attached to RTECO-2742.