Skip to content

RTECO-1368 - Fix metrics collection for agent detection and interactive context fields - #3518

Merged
fluxxBot merged 1 commit into
masterfrom
RTECO-1368-Fix-AgentMetric
May 28, 2026
Merged

RTECO-1368 - Fix metrics collection for agent detection and interactive context fields#3518
fluxxBot merged 1 commit into
masterfrom
RTECO-1368-Fix-AgentMetric

Conversation

@fluxxBot

@fluxxBot fluxxBot commented May 27, 2026

Copy link
Copy Markdown
Contributor
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

RTECO-1368: Fix dropped agent metric labels (is_agent, agent, is_interactive)

Problem

PR #1555 (RTECO-1017) added agent/CI context fields to MetricsData and
populated them in metrics_collector.go, but the labels were silently dropped
on the way to the visibility wire payload. Prod logs (jfcli_commands_count)
still don't show is_agent, agent, or is_interactive.

Root cause

Two broken links in the chain:

  1. commandsCountLabels struct in commands_count_metric.go had no fields
    for the new agent labels, so they could never be serialized.
  2. reportUsageToVisibilitySystem in command.go didn't copy the new
    fields from collected MetricsData into visibility.MetricsData.

Depends on:

  1. core - RTECO-1368 - Fix metrics collection for agent detection and interactive context fields jfrog-cli-core#1566

@fluxxBot fluxxBot added the bug Something isn't working label May 27, 2026
@fluxxBot
fluxxBot force-pushed the RTECO-1368-Fix-AgentMetric branch from d26d257 to fb3bd71 Compare May 27, 2026 19:32
@fluxxBot
fluxxBot force-pushed the RTECO-1368-Fix-AgentMetric branch from fb3bd71 to 7e7c81a Compare May 27, 2026 19:41
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label May 27, 2026
@fluxxBot fluxxBot mentioned this pull request May 27, 2026
Merged
4 tasks
@fluxxBot
fluxxBot force-pushed the RTECO-1368-Fix-AgentMetric branch from 7e7c81a to a25d8ce Compare May 27, 2026 20:54
@fluxxBot fluxxBot added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels May 27, 2026
@fluxxBot
fluxxBot force-pushed the RTECO-1368-Fix-AgentMetric branch from a25d8ce to a39c3bc Compare May 27, 2026 21:02
@fluxxBot fluxxBot added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels May 27, 2026
@fluxxBot
fluxxBot requested a review from bhanurp May 28, 2026 05:34
@fluxxBot
fluxxBot force-pushed the RTECO-1368-Fix-AgentMetric branch from a39c3bc to ab1fc6c Compare May 28, 2026 06:13
@fluxxBot fluxxBot added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels May 28, 2026
@fluxxBot
fluxxBot enabled auto-merge (squash) May 28, 2026 06:14
@fluxxBot
fluxxBot merged commit 2f3acd3 into master May 28, 2026
95 of 99 checks passed
@fluxxBot
fluxxBot deleted the RTECO-1368-Fix-AgentMetric branch May 28, 2026 06:38
@BrewTestBot BrewTestBot mentioned this pull request May 28, 2026
Merged
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
HarmonybrewBot HarmonybrewBot
!8877 merge bump-jfrog-cli-2.105.0 into main
1da5be5 
jfrog-cli 2.105.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>## What changed in v2.105.0

> Auto-generated from 6 repositories · 2026-05-28  
> Comparing `v2.104.1` → `v2.105.0`

> ℹ️  No changes in: gofrog

### ✨ New Features

- **[build-info-go]** added nix package manager support [#378](jfrog/build-info-go#378) (@reshmifrog)
- **[jfrog-cli]** add nix package manager support [#3471](jfrog/jfrog-cli#3471) (@reshmifrog)
- **[jfrog-cli-artifactory]** RTECO-1266 - Implement ai plugins publish command [#454](jfrog/jfrog-cli-artifactory#454) (@udaykb2)
- **[jfrog-cli-artifactory]** add nix package manager [#442](jfrog/jfrog-cli-artifactory#442) (@reshmifrog)
- **[jfrog-cli-core]** RTECO-1266 - Add Subcommand to command [#1560](jfrog/jfrog-cli-core#1560) (@udaykb2)
- **[jfrog-cli-security]** XRAY-140488 - Implement graceful dotnet restore error for all dotnet … [#752](jfrog/jfrog-cli-security#752) (@gauriy-tech)

### 🐛 Bug Fixes

- **[jfrog-cli]** RTECO-1368 - Fix metrics collection for agent detection and interactive context fields [#3518](jfrog/jfrog-cli#3518) (@fluxxBot)
- **[jfrog-cli-artifactory]** Fix: Return error when jfrog server is not configured [#459](jfrog/jfrog-cli-artifactory#459) (@udaykb2)
- **[jfrog-cli-core]** RTECO-1368 - Fix metrics collection for agent detection and interactive context fields [#1566](jfrog/jfrog-cli-core#1566) (@fluxxBot)
- **[jfrog-cli-security]** Fix nil dereference issue regarding Applicability Scan results [#755](jfrog/jfrog-cli-security#755) (@eranturgeman)
- **[jfrog-cli-security]** Populate project key to GetConfigProfileByUrl [#763](jfrog/jfrog-cli-security#763) (@eranturgeman)
- **[jfrog-cli-security]** Adjust rtRepository path when in project context [#764](jfrog/jfrog-cli-security#764) (@eranturgeman)

### 🔧 Internal Changes

- **[jfrog-cli-security]** Update AnalyzerManager default version to 1.34.1 [#754](jfrog/jfrog-cli-security#754) (@attiasas)
- **[jfrog-cli-security]** Update dependencies for 1.29.2 [#765](jfrog/jfrog-cli-security#765) (@eranturgeman)

### 📦 Other Changes

- **[jfrog-cli]** Enable JSON error output for commands with HTTP requests [#3493](jfrog/jfrog-cli#3493) (@ehl-jf)
- **[jfrog-cli]** Make jf uv command publicly available [#3511](jfrog/jfrog-cli#3511) (@agrasth)
- **[jfrog-cli-artifactory]** RTECO-1266 - Rename ai plugins to agent plugins [#456](jfrog/jfrog-cli-artifactory#456) (@udaykb2)
- **[jfrog-client-go]** Expose full HTTP response in case of error [#1345](jfrog/jfrog-client-go#1345) (@ehl-jf)

---

### 📊 Summary

| Repository | Changes |
|---|---|
| [jfrog-cli-security](https://github.com/jfrog/jfrog-cli-security) | 6 |
| [jfrog-cli](https://github.com/jfrog/jfrog-cli) | 4 |
| [jfrog-cli-artifactory](https://github.com/jfrog/jfrog-cli-artifactory) | 4 |
| [jfrog-cli-core](https://github.com/jfrog/jfrog-cli-core) | 2 |
| [build-info-go](https://github.com/jfrog/build-info-go) | 1 |
| [jfrog-client-go](https://github.com/jfrog/jfrog-client-go) | 1 |
| **Total** | **18** |

### 🔗 Module Version Changes

| Module | From | To |
|---|---|---|
| [build-info-go](https://github.com/jfrog/build-info-go) | `v1.13.1-0.20260521104402-1e35b9b5b0c6` | `v1.13.1-0.20260526201157-3dd942bd9e1f` |
| [jfrog-cli-artifactory](https://github.com/jfrog/jfrog-cli-artifactory) | `v0.8.1-0.20260520131142-ef80a14dd499` | `v0.8.1-0.20260527043943-fdf755c4f4c2` |
| [jfrog-cli-core](https://github.com/jfrog/jfrog-cli-core) | `v2.60.1-0.20260520130103-75be6a23c54b` | `v2.60.1-0.20260528061115-b41c87af0194` |
| [jfrog-cli-security](https://github.com/jfrog/jfrog-cli-security) | `v1.29.0` | `v1.29.2` |
| [jfrog-client-go](https://github.com/jfrog/jfrog-client-go) | `v1.55.1-0.20260521115926-32f082854b39` | `v1.55.1-0.20260527095031-a0b759bcd723` |
</pre>
  <p>View the full release notes at <a href="https://github.com/jfrog/jfrog-cli/releases/tag/v2.105.0">https://github.com/jfrog/jfrog-cli/releases/tag/v2.105.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!8877

This branch had an error being deployed

1 failed deployment
frogbot — ab1fc6c0 Deployed May 28, 2026 by fluxxBot via scan-pull-request #4342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhanurp bhanurp bhanurp approved these changes

Assignees

No one assigned

Labels

bug Something isn't working safe to test Approve running integration tests on a pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fluxxBot @bhanurp