Repository navigation
Attribute release-bump commit to the gh-authenticated user - #3500
Merged
Merged
Conversation
The release-prep script hardcoded the git committer to github-actions[bot] but used the running gh token to open the PR and add the "ignore for release" label. Locally that produced PRs where the commit, the PR opener, and the label event disagreed. Resolve the gh identity once via `gh api user`, then set GIT_AUTHOR_*/GIT_COMMITTER_* env vars on the bump commit. In CI with GITHUB_TOKEN the user is github-actions[bot] (unchanged); locally it's the real user. Fall back to github-actions[bot] if `gh api user` fails.
ehl-jf
added
ignore for release
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release-prep script hardcoded the git committer to github-actions[bot] but used the running gh token to open the PR and add the "ignore for release" label. Locally that produced PRs where the commit, the PR opener, and the label event disagreed.
Resolve the gh identity once via
gh api user, then set GIT_AUTHOR_/GIT_COMMITTER_ env vars on the bump commit. In CI with GITHUB_TOKEN the user is github-actions[bot] (unchanged); locally it's the real user. Fall back to github-actions[bot] ifgh api userfails.masterbranch.go vet ./....go fmt ./....