Skip to content

Fix release script: derive next version from local current version - #3498

Merged
ehl-jf merged 1 commit into
masterfrom
fix-release-script
May 20, 2026
Merged

ehl-jf merged 1 commit into
masterfrom
fix-release-script

Conversation

@ehl-jf

@ehl-jf ehl-jf commented May 20, 2026 •

Copy link
Copy Markdown
Contributor

compute_next_version was reading the latest GitHub release tag, while compute_current_version reads the local CliVersion. After a bump PR merges, the local version is one ahead of the latest release tag, so both computations produced the same value and the branch ended up as bump-ver-from-X-to-X. Increment the local current_version instead.

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

compute_next_version was reading the latest GitHub release tag, while
compute_current_version reads the local CliVersion. After a bump PR
merges, the local version is one ahead of the latest release tag, so
both computations produced the same value and the branch ended up as
bump-ver-from-X-to-X. Increment the local current_version instead.
@ehl-jf ehl-jf added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels May 20, 2026
@ehl-jf
ehl-jf merged commit 4867399 into master May 20, 2026
111 of 113 checks passed
@ehl-jf
ehl-jf deleted the fix-release-script branch May 20, 2026 12:19

This branch had an error being deployed

1 failed deployment
frogbot — d12ac530 Deployed May 20, 2026 by ehl-jf via scan-pull-request #4272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants