Repository navigation
Fix UV and Maven test failures - #3462
Merged
Merged
Conversation
agrasth
added
the
safe to test
agrasth
added
safe to test
agrasth
changed the title
agrasth
marked this pull request as ready for review
April 29, 2026 12:32
…URL to prevent enrichment from leaked env vars
… correct server ID
agrasth
added
safe to test
agrasth
force-pushed
the
fix/uv-test-failures
branch
from
April 29, 2026 13:14
9fb92ff to
5cf0159
Compare
agrasth
added
safe to test
…to avoid partial file bleed
agrasth
added
safe to test
bhanurp
reviewed
Apr 29, 2026
| if err != nil { | ||
| return err | ||
| } | ||
| // urfave/cli v1 reorders defined flags to the front and parses them before UvCmd |
Contributor
Author
There was a problem hiding this comment.
You are right, it's not needed. When TestUvModuleOverrideOnPublish and TestUvServerIDFlag were failing, I assumed urfave/cli v1 was consuming --module and --server-id before UvCmd saw them — based on the reorderArgs behavior. So I added c.String("module") and c.String("server-id") as fallbacks.
But SkipFlagParsing: true was already on the UV command from the original PR. With that set, urfave/cli skips ALL flag parsing, which dumps everything straight into c.Args(). So c.String() always returns "", and the fallbacks never executed.
They were dead code. I have removed it
| if err != nil { | ||
| return fmt.Errorf("failed to extract server ID: %w", err) | ||
| } | ||
| if serverID == "" { |
Contributor
There was a problem hiding this comment.
isnt serverID read in previous step why is extra check required and why is it set again by reading from flagvalue?
…y puts all args in c.Args()
agrasth
added
safe to test
agrasth
added
ignore for release
bhanurp
approved these changes
Apr 30, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....