Repository navigation
test: Add E2E coverage for helm push OCI subpaths and build-info modu… - #3455
Merged
Merged
Conversation
naveenku-jfrog
had a problem deploying
to
frogbot
April 27, 2026 05:58 — with 
GitHub Actions
Failure
GitHub Actions
Failure
naveenku-jfrog
force-pushed
the
test/helm-push-oci-subpath-e2e
branch
from
April 27, 2026 06:02
1debc28 to
e87f88f
Compare
naveenku-jfrog
had a problem deploying
to
frogbot
April 27, 2026 06:02 — with
GitHub Actions
Failure
GitHub Actions
Failure
naveenku-jfrog
force-pushed
the
test/helm-push-oci-subpath-e2e
branch
from
April 27, 2026 06:04
e87f88f to
7bca97d
Compare
naveenku-jfrog
had a problem deploying
to
frogbot
April 27, 2026 06:04 — with
GitHub Actions
Failure
GitHub Actions
Failure
naveenku-jfrog
added
the
safe to test
…le coexistence Adds three integration tests in helm_test.go that exercise the behaviours hardened in jfrog/jfrog-cli-artifactory#430: - TestHelmPushWithSubpath: pushing to oci://<host>/<repo>/team-alpha stores the chart at <repo>/team-alpha/<chart>/<version> (sub-path is honoured). - TestHelmPushWithMultiLevelSubpath: the same behaviour holds for deeply nested sub-paths (oci://<host>/<repo>/org/team-beta/project-gamma). - TestHelmPushModuleCoexistenceAfterExistingModule: when the partial build info already contains a non-helm module (seeded via rt build-add-dependencies), helm push must add its helm module alongside the existing one instead of dropping the helm artifacts. Also introduces shared helpers (packageHelmChartForPush, helmSubpathRegistryURL, runHelmSubpathPushTest, assertOCIArtifactsUnderSubpath, and the maybeSkipHelm* skip helpers) so the new tests and the existing helm suite share the OCI-endpoint / HTTPS / account-lockout skip logic. No production code changes; tests-only. Made-with: Cursor
naveenku-jfrog
force-pushed
the
test/helm-push-oci-subpath-e2e
branch
from
April 27, 2026 06:15
7bca97d to
10ec9b9
Compare
naveenku-jfrog
had a problem deploying
to
frogbot
April 27, 2026 06:15 — with
GitHub Actions
Failure
GitHub Actions
Failure
naveenku-jfrog
added
safe to test
bhanurp
approved these changes
Apr 28, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three integration tests in helm_test.go that exercise the behaviours hardened in jfrog/jfrog-cli-artifactory#430:
Also introduces shared helpers (packageHelmChartForPush, helmSubpathRegistryURL, runHelmSubpathPushTest, assertOCIArtifactsUnderSubpath, and the maybeSkipHelm* skip helpers) so the new tests and the existing helm suite share the OCI-endpoint / HTTPS / account-lockout skip logic.
No production code changes; tests-only.
masterbranch.go vet ./....go fmt ./....