Repository navigation
fix: build+pattern downloads against virtual repos - #3449
Merged
bhanurp merged 6 commits intoApr 24, 2026
Merged
Conversation
Add replace directive pointing at jfrog-client-go branch fix/build-with-pattern-virtual-repo so CI picks up the virtual-repo pattern-download fix (client-go PR).
Guards the jfrog-client-go fix that moves the pattern filter from client-side post-filter (which compared against the backing local repo returned by AQL) to AQL server-side (which resolves virtual repos).
bhanurp
added
bug
Both funnel into SearchBySpecWithBuild and both returned empty results pre-fix when combining --build with a virtual-repo pattern. Guards the spec parser path and the sibling search command alongside the existing CLI-args download test.
bhanurp
added
safe to test
bhanurp
requested review from
a team,
agrasth,
fluxxBot,
itsmeleela,
naveenku-jfrog and
reshmifrog
and removed request for
a team
April 22, 2026 04:26
fluxxBot
approved these changes
Apr 22, 2026
Hardcoded build numbers risk colliding with state left by a previously crashed run. Swap to a timestamped uniqueBuildNumberPair helper and generate the spec-file variant inline so the build number propagates cleanly without a fixture. Drops the now-unused fixture/constant. Addresses PR review feedback on jfrog#3449.
bhanurp
added
safe to test
bhanurp
added
safe to test
naveenku-jfrog
added a commit
that referenced
this pull request
May 4, 2026
Commit 447a825 (RTECO-1003) accidentally deleted three test functions and two helpers that were introduced by commit 9133283 (fix: build+pattern downloads against virtual repos, PR #3449): - TestArtifactoryDownloadByPatternAndBuildFromVirtualRepo - TestArtifactoryDownloadByPatternAndBuildFromVirtualRepoUsingSpec - TestArtifactorySearchByPatternAndBuildFromVirtualRepo - uniqueBuildNumberPair (helper) - writeBuildPatternVirtualSpec (helper) These tests guard the jfrog-client-go fix for virtual-repo AQL pattern resolution and are executed by the jfrog-cli workflows. Restore them verbatim from commit 9133283. Co-authored-by: Cursor <cursoragent@cursor.com>
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replacedirective ingo.modpointinggithub.com/jfrog/jfrog-client-goat thefix/build-with-pattern-virtual-repobranch so CI exercises the virtual-repo pattern-download fix.Test plan
jf rt download --build=<build>/<number> "<virtual-repo>/**"returns the expected artifacts