Skip to content

RTECO-1049 - switch between podman and docker - #3442

Merged
fluxxBot merged 5 commits into
masterfrom
RTECO-1049-docker-ado
Apr 18, 2026
Merged

RTECO-1049 - switch between podman and docker#3442
fluxxBot merged 5 commits into
masterfrom
RTECO-1049-docker-ado

Conversation

@fluxxBot

@fluxxBot fluxxBot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Apr 17, 2026
@fluxxBot
fluxxBot requested review from a team, agrasth, bhanurp, itsmeleela, naveenku-jfrog and reshmifrog and removed request for a team April 17, 2026 10:18
itsmeleela
itsmeleela reviewed Apr 17, 2026
View reviewed changes
Comment thread buildtools/cli.go Resolved
itsmeleela
itsmeleela reviewed Apr 17, 2026
View reviewed changes
Comment thread buildtools/cli.go Resolved
@fluxxBot
Enhance container manager detection in 'jf docker' commands to suppor…
700fc0e 
…t Podman. Implemented a new function to check if the local 'docker' CLI is backed by Podman, allowing seamless usage for users without daemon-socket access.
@fluxxBot
fluxxBot force-pushed the RTECO-1049-docker-ado branch from 38c0586 to 700fc0e Compare April 17, 2026 11:15
@fluxxBot fluxxBot added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Apr 17, 2026
@fluxxBot fluxxBot added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Apr 17, 2026
bhanurp
bhanurp requested changes Apr 17, 2026
View reviewed changes
Comment thread buildtools/cli.go Resolved
Comment thread buildtools/cli.go Resolved
Comment thread buildtools/cli.go Resolved
@fluxxBot fluxxBot added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Apr 17, 2026
@fluxxBot
fluxxBot requested review from bhanurp and itsmeleela April 17, 2026 18:08
@fluxxBot
fluxxBot enabled auto-merge (squash) April 18, 2026 08:54
@fluxxBot fluxxBot added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Apr 18, 2026
@fluxxBot
fluxxBot merged commit 799be95 into master Apr 18, 2026
79 of 80 checks passed
@fluxxBot
fluxxBot deleted the RTECO-1049-docker-ado branch April 18, 2026 09:47
@BrewTestBot BrewTestBot mentioned this pull request Apr 18, 2026
Merged

This branch had an error being deployed

1 failed deployment
frogbot — 00ddd901 Deployed Apr 18, 2026 by fluxxBot via scan-pull-request #4037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhanurp bhanurp bhanurp approved these changes
@agrasth agrasth Awaiting requested review from agrasth agrasth was automatically assigned from jfrog/ecomatrix
@reshmifrog reshmifrog Awaiting requested review from reshmifrog reshmifrog was automatically assigned from jfrog/ecomatrix
@naveenku-jfrog naveenku-jfrog Awaiting requested review from naveenku-jfrog naveenku-jfrog was automatically assigned from jfrog/ecomatrix
@itsmeleela itsmeleela Awaiting requested review from itsmeleela

Assignees

No one assigned

Labels

safe to test Approve running integration tests on a pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fluxxBot @itsmeleela @bhanurp