Skip to content

Jfrogpipelines - #3422

Merged
naveenku-jfrog merged 1 commit into
masterfrom
jfrogpipelines
May 4, 2026
Merged

Jfrogpipelines#3422
naveenku-jfrog merged 1 commit into
masterfrom
jfrogpipelines

Conversation

@naveenku-jfrog

@naveenku-jfrog naveenku-jfrog commented Apr 9, 2026 •
edited by agrasth
Loading

Copy link
Copy Markdown
Collaborator
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Updated pipelines.yml and access.test so that these tests become compatible with tests running in GHE runners.

@naveenku-jfrog naveenku-jfrog added the safe to test Approve running integration tests on a pull request label Apr 9, 2026
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Apr 9, 2026
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Apr 9, 2026
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Apr 9, 2026
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Apr 9, 2026
bhanurp
bhanurp reviewed Apr 28, 2026
View reviewed changes
Comment thread .github/workflows/helmTests.yml
Comment on lines +4 to +14
inputs:
jfrog_url:
description: "External JFrog Platform URL. Leave empty for local Artifactory."
type: string
required: false
default: ""
jfrog_admin_token:
description: "Admin token for external JFrog Platform."
type: string
required: false
default: ""

@bhanurp bhanurp Apr 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like repeating pattern fr all the files can it be made generic?

@naveenku-jfrog naveenku-jfrog Apr 29, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions has no mechanism to share or inherit workflow_dispatch input definitions across workflow files. Each file must declare its own inputs independently — this is a documented platform limitation, not a design choice we can easily escape.

Comment thread .github/workflows/pluginsTests.yml
run: go test -v github.com/jfrog/jfrog-cli --timeout 0 --test.plugins
run: >-
go test -v github.com/jfrog/jfrog-cli --timeout 0 --test.plugins
${{ env.JFROG_TESTS_IS_EXTERNAL == 'true' && format('--jfrog.url={0} --jfrog.adminToken={1}', env.JFROG_TESTS_URL, env.JFROG_TESTS_LOCAL_ACCESS_TOKEN) || '' }}

@bhanurp bhanurp Apr 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since token is used here, does tests leak the token used fr tests? were you able to verify?

@naveenku-jfrog naveenku-jfrog Apr 30, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the already used style in all workflows. Refer: https://github.com/jfrog/jfrog-cli/blob/master/.github/workflows/artifactoryTests.yml#L82

@naveenku-jfrog @cursoragent
RTECO-1003 - jfrog-cli pipeline and test hardening for external Artif…
8d3db4e 
…actory

- Update pipelines.yml and workflow files so tests run correctly against
  external (cloud) Artifactory from GHE-hosted runners
- Skip TestReleaseBundleImportOnPrem on snapshot Artifactory versions
- Skip bulk repo create/update subtests on snapshot Artifactory versions
- Drop transferTests.yml from the JFrog Pipelines dispatch list
- Fix nested-path Docker tests: remove .Build() filter to avoid SDK reader panic
- Exclude TestNpmPublishWithNpmrc, TestNpmPublishWithNpmrcScoped and
  TestNpmPublishWithWorkspacesRunNative via workflow-level -skip flag
- Fix TestMavenDeploy: add ensureMavenRepoCleanOfDeployedArtifacts() and
  increase assertMavenArtifactsEventuallyNotDeployed pollTimeout to 3 minutes
- Harden NuGet retry: wrap runNuGet() with execNuGetWithTransientRetry()
- Fix TestGradleBuildWithServerID flakiness: retry artifact search for async indexing
- Fix TestSetupGradleCommand: evict remote-repo cache before precondition check
- Restore virtual-repo build+pattern test cases (TestArtifactoryDownloadByPatternAndBuildFromVirtualRepo,
  TestArtifactoryDownloadByPatternAndBuildFromVirtualRepoUsingSpec,
  TestArtifactorySearchByPatternAndBuildFromVirtualRepo)
- Point install-local-artifactory action to @main
- Point jfrog-cli-workflows ref to master after bugfix branch was merged

Co-authored-by: Cursor <cursoragent@cursor.com>

This branch had an error being deployed

1 failed deployment
frogbot — 8d3db4eb Deployed May 4, 2026 by naveenku-jfrog via scan-pull-request #4170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhanurp bhanurp bhanurp approved these changes
@agrasth agrasth agrasth approved these changes

Assignees

No one assigned

Labels

ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@naveenku-jfrog @bhanurp @agrasth