Repository navigation
Addressed bugs/improvements in huggingface bughunts - #3395
Merged
naveenku-jfrog merged 7 commits intoMar 25, 2026
Merged
naveenku-jfrog merged 7 commits into
naveenku-jfrog merged 7 commits into
Conversation
naveenku-jfrog
added
safe to test
naveenku-jfrog
force-pushed
the
fix/RTECO-957-Hugging-Face-Bughunt-Improvments-bugs
branch
from
March 25, 2026 06:13
deac5dd to
1ee6043
Compare
naveenku-jfrog
added
safe to test
naveenku-jfrog
added
safe to test
agrasth
approved these changes
Mar 25, 2026
Comment on lines
+1766
to
+1767
| HfHubEtagTimeout: cli.StringFlag{ | ||
| Name: HfHubEtagTimeout, |
Contributor
There was a problem hiding this comment.
HfHubEtagTimeout defined as StringFlag but should be IntFlag?
Collaborator
Author
There was a problem hiding this comment.
Addressed it.
| } | ||
|
|
||
| func updateHuggingFaceEnv(c *cli.Context, serverDetails *coreConfig.ServerDetails) error { | ||
| if os.Getenv(HF_ENDPOINT) == "" { |
Contributor
There was a problem hiding this comment.
Removed checks for existing HF_ENDPOINT and HF_TOKEN env vars - now always overwrites. Is this intentional behavior change?
Collaborator
Author
There was a problem hiding this comment.
If user has provided --repo-key flag, then its mandatory to set HF_ENDPOINT env value.
Contributor
|
|
agrasth
reviewed
Mar 25, 2026
| @@ -1183,28 +1199,30 @@ func huggingFaceUploadCmd(c *cli.Context, cmdName string, hfArgs []string) error | |||
| if repoType == "" { | |||
Contributor
There was a problem hiding this comment.
Repo type validation only in upload command, not download. Should both validate?
Collaborator
Author
There was a problem hiding this comment.
Addressed it.
naveenku-jfrog
added
safe to test
Contributor
naveenku-jfrog
deleted the
fix/RTECO-957-Hugging-Face-Bughunt-Improvments-bugs
branch
March 25, 2026 12:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....What: Addressed the bugs and improvements found out in buhunt session.
Testing: Done, artifactory instance.