Repository navigation
New Feature: Implement package alias to invoke jfrog-cli based on package manager - #3375
Merged
Merged
Conversation
Moved alias enable/disable state into config.yaml Added Sync() before atomic rename during config writes to reduce risk of config loss/corruption on crashes.
bhanurp
removed
the
safe to test
bhanurp
requested review from
a team,
agrasth,
fluxxBot,
itsmeleela,
naveenku-jfrog and
reshmifrog
and removed request for
a team
April 8, 2026 11:26
bhanurp
added
the
safe to test
itsmeleela
approved these changes
Apr 8, 2026
bhanurp
added
safe to test
bhanurp
added
safe to test
bhanurp
enabled auto-merge (squash)
April 9, 2026 11:27
bhanurp
disabled auto-merge
April 9, 2026 11:50
SierraNL
added a commit
to SierraNL/jfrog-azure-devops-extension
that referenced
this pull request
Sep 15, 2026
… leak on failure - minSupportedPackageAliasCliVersion was 2.93.0, but the package-alias command doesn't exist until CLI 2.100.0 (jfrog/jfrog-cli#3375, merged 2026-04-09, first included in tag v2.100.0). Verified by installing jf.exe 2.93.0, 2.99.0 and 2.100.0 directly and confirming 'jf package-alias' is unrecognized on the first two and works on the latter. Any CLI in [2.93.0, 2.100.0) was passing the gate and then failing with an unrecognized-command error - exactly what the gate was meant to prevent. - setUpPackageAlias() was called before the try/finally in RunTaskCbk, so a throw from it (e.g. hitting the bug above, or any package-alias install failure) skipped taskDefaultCleanup and leaked the CLI server config. Moved the call inside the try block so it's covered by the existing catch/finally. Addresses review comments from agrasth on PR jfrog#652. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....Description
The feature allows transparent interception of package manager commands (e.g., npm, mvn, go) by symlinking or copying the jf binary to these names in a dedicated directory and adding that directory to the PATH.