Skip to content

Fix/lifecycle tests local artifactory - #3261

Merged
agrasth merged 7 commits into
masterfrom
fix/lifecycle-tests-local-artifactory
Dec 10, 2025
Merged

agrasth merged 7 commits into
masterfrom
fix/lifecycle-tests-local-artifactory

Conversation

@agrasth

@agrasth agrasth commented Dec 9, 2025 •

Copy link
Copy Markdown
Contributor
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

…ta issues

## Problem
Lifecycle tests were failing with 'Cannot create project, Max number of
projects is reached' because they used a shared remote platform that
accumulated orphaned test projects from failed test runs.

## Solution
Switch lifecycle tests to use local Artifactory installation, matching
the pattern used by all other test suites.

## Changes
- Use jfrog/.github/actions/install-local-artifactory@main
- Connect to http://127.0.0.1:8082 instead of secrets.PLATFORM_URL
- Use auto-generated JFROG_TESTS_LOCAL_ACCESS_TOKEN
- Add macOS skip logic (JGC-413)
- Explicit OS version matrix for consistency
- Fix syntax error in deleteProjectIfExists: t.Error(t, err) -> t.Error(err)

## Benefits
- No shared state between test runs
- No manual cleanup required
- Better test isolation
- Consistent with other test workflows
- Each test run gets fresh Artifactory instance
…ta issues

- Switch lifecycle tests from remote platform to local Artifactory installation
- Aligns with pattern used by all other test suites (artifactory, transfer, access, etc.)
- Fixes syntax error in deleteProjectIfExists (t.Error(t, err) -> t.Error(err))
- Each test run gets fresh Artifactory instance, eliminating project accumulation
- Resolves 'Cannot create project, Max number of projects is reached' errors

Changes:
- Use jfrog/.github/actions/install-local-artifactory@main
- Connect to http://127.0.0.1:8082 instead of secrets.PLATFORM_URL
- Use auto-generated JFROG_TESTS_LOCAL_ACCESS_TOKEN
- Add macOS skip logic (JGC-413)
- Explicit OS version matrix for consistency

Benefits:
- No shared state between test runs
- No manual cleanup required
- Better test isolation
- Consistent with other test workflows
@agrasth
agrasth force-pushed the fix/lifecycle-tests-local-artifactory branch from ecf83a6 to b49c4ac Compare December 9, 2025 21:49
@agrasth agrasth added the safe to test Approve running integration tests on a pull request label Dec 9, 2025
@bhanurp
bhanurp self-requested a review December 10, 2025 05:23
@agrasth agrasth added ignore for release Automatically generated release notes and removed safe to test Approve running integration tests on a pull request labels Dec 10, 2025
@github-actions

Copy link
Copy Markdown
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@agrasth agrasth added the safe to test Approve running integration tests on a pull request label Dec 10, 2025
@agrasth
agrasth merged commit acbcb93 into master Dec 10, 2025
71 of 77 checks passed
@agrasth
agrasth deleted the fix/lifecycle-tests-local-artifactory branch December 10, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants