Repository navigation
Conversation
agrasth
commented
Dec 9, 2025
| err := accessManager.DeleteProject(projectKey) | ||
| if err != nil { | ||
| if !strings.Contains(err.Error(), "Could not find project") { | ||
| t.Error(t, err) |
Contributor
Author
There was a problem hiding this comment.
t.Error(t, err) : Tries to print the testing object itself, then the error
…ta issues ## Problem Lifecycle tests were failing with 'Cannot create project, Max number of projects is reached' because they used a shared remote platform that accumulated orphaned test projects from failed test runs. ## Solution Switch lifecycle tests to use local Artifactory installation, matching the pattern used by all other test suites. ## Changes - Use jfrog/.github/actions/install-local-artifactory@main - Connect to http://127.0.0.1:8082 instead of secrets.PLATFORM_URL - Use auto-generated JFROG_TESTS_LOCAL_ACCESS_TOKEN - Add macOS skip logic (JGC-413) - Explicit OS version matrix for consistency - Fix syntax error in deleteProjectIfExists: t.Error(t, err) -> t.Error(err) ## Benefits - No shared state between test runs - No manual cleanup required - Better test isolation - Consistent with other test workflows - Each test run gets fresh Artifactory instance
agrasth
force-pushed
the
fix/lifecycle-tests-local-artifactory
branch
from
December 9, 2025 10:27
d822178 to
85efe66
Compare
agrasth
added
ignore for release
agrasth
removed
the
safe to test
agrasth
added
the
safe to test
agrasth
added
safe to test
…ta issues - Switch lifecycle tests from remote platform to local Artifactory installation - Aligns with pattern used by all other test suites (artifactory, transfer, access, etc.) - Fixes syntax error in deleteProjectIfExists (t.Error(t, err) -> t.Error(err)) - Each test run gets fresh Artifactory instance, eliminating project accumulation - Resolves 'Cannot create project, Max number of projects is reached' errors Changes: - Use jfrog/.github/actions/install-local-artifactory@main - Connect to http://127.0.0.1:8082 instead of secrets.PLATFORM_URL - Use auto-generated JFROG_TESTS_LOCAL_ACCESS_TOKEN - Add macOS skip logic (JGC-413) - Explicit OS version matrix for consistency Benefits: - No shared state between test runs - No manual cleanup required - Better test isolation - Consistent with other test workflows
agrasth
added
safe to test
Added condition to skip lifecycle tests based on TestLifecycle flag.
agrasth
added
safe to test
Contributor
fluxxBot
approved these changes
Dec 9, 2025
fluxxBot
added
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....