Skip to content

Feature/added native helm commands support - #3235

Merged
naveenku-jfrog merged 33 commits into
jfrog:masterfrom
naveenku-jfrog:feature/Added-native-helm-commands-support
Dec 10, 2025
Merged

Feature/added native helm commands support#3235
naveenku-jfrog merged 33 commits into
jfrog:masterfrom
naveenku-jfrog:feature/Added-native-helm-commands-support

Conversation

@naveenku-jfrog

@naveenku-jfrog naveenku-jfrog commented Nov 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

what: Added native helm commands support without collecting build information.
Dependent on other PRs: No
Testing: Done, locally

@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Nov 21, 2025
@reshmifrog
reshmifrog self-requested a review November 25, 2025 06:32
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Nov 26, 2025
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Nov 26, 2025
reshmifrog
reshmifrog reviewed Nov 26, 2025
View reviewed changes
Comment thread docs/buildtools/helmcommand/help.go
return "Run native Helm command"
}

func GetArguments() string {

@reshmifrog reshmifrog Nov 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add examples on how to use it

@naveenku-jfrog
naveenku-jfrog enabled auto-merge (squash) November 26, 2025 15:46
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Nov 26, 2025
nitinp19
nitinp19 approved these changes Dec 1, 2025
View reviewed changes

@nitinp19 nitinp19 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just verify if we have a provision to provide the flags and do we need to filter them, when running the helm command.
check why the static analysis is failing

@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 3, 2025
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 10, 2025
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 10, 2025
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 10, 2025
@agrasth
agrasth requested review from agrasth and ehl-jf and removed request for agrasth December 10, 2025 14:36
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 10, 2025
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 10, 2025
agrasth
agrasth reviewed Dec 10, 2025
View reviewed changes
Comment thread buildtools/cli.go Resolved
agrasth
agrasth reviewed Dec 10, 2025
View reviewed changes
Comment thread docs/buildtools/helmcommand/help.go Resolved
@naveenku-jfrog naveenku-jfrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 10, 2025
@github-actions

github-actions Bot commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

@BrewTestBot BrewTestBot mentioned this pull request Dec 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reshmifrog reshmifrog reshmifrog approved these changes
@agrasth agrasth agrasth approved these changes
@bhanurp bhanurp bhanurp left review comments
+1 more reviewer
@nitinp19 nitinp19 nitinp19 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

safe to test Approve running integration tests on a pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@naveenku-jfrog @bhanurp @agrasth @reshmifrog @nitinp19