Skip to content

bugfix for poetry flexpack - #3174

Merged
agrasth merged 2 commits into
jfrog:masterfrom
agrasth:poetryFlexpack
Oct 27, 2025
Merged

agrasth merged 2 commits into
jfrog:masterfrom
agrasth:poetryFlexpack

Conversation

@agrasth

@agrasth agrasth commented Oct 23, 2025 •

Copy link
Copy Markdown
Contributor
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Fix: Add Poetry FlexPack Native Routing

Added FlexPack routing check to pythonCmd() in buildtools/cli.go (similar to Maven implementation):

  • Detects JFROG_RUN_NATIVE=true for Poetry commands
  • Executes native poetry command directly (no poetry update)
  • Collects build info via existing GetPoetryBuildInfo()

Changes

  • File: jfrog-cli/buildtools/cli.go
  • Lines: 1216-1251 (36 lines added)
  • Import: Added github.com/jfrog/jfrog-cli/utils/buildinfo

Result

  • poetry.lock remains unchanged
  • Reproducible builds
  • Build info collection works
  • No config file required in native mode

Usage

export JFROG_RUN_NATIVE=true
jf poetry install --build-name=my-build --build-number=1

@agrasth
agrasth requested a review from fluxxBot October 23, 2025 14:48
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Oct 23, 2025
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Oct 23, 2025
@agrasth agrasth changed the title Minor bugfix for poetry flexpack bugfix for poetry flexpack Oct 23, 2025
@agrasth agrasth added the ignore for release Automatically generated release notes label Oct 23, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Oct 24, 2025
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Oct 24, 2025
Comment thread buildtools/cli.go Outdated
if err := buildinfo.GetPoetryBuildInfo(workingDir, buildConfiguration); err != nil {
log.Warn("Failed to collect Poetry build info: " + err.Error())
} else {
buildNumber, _ := buildConfiguration.GetBuildNumber()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we ignoring error here?

@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Oct 27, 2025
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Oct 27, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Oct 27, 2025
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Oct 27, 2025
@github-actions

Copy link
Copy Markdown
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@agrasth
agrasth merged commit 7a66e9e into jfrog:master Oct 27, 2025
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants