Skip to content

Updating test data and dependency for jf rbs command #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveenku-jfrog merged 3 commits into from
Oct 16, 2025
Merged

Updating test data and dependency for jf rbs command #3163

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cf4d6f
Updating test data and dependency for jf rbs command
naveenku-jfrog Oct 15, 2025
337be41
Removing lint errors
naveenku-jfrog Oct 15, 2025
ba317e4
Merge branch 'master' into feature/RTECO-456-Implement-Groups-API-amn…
naveenku-jfrog Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
297 changes: 297 additions & 0 deletions lifecycle_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"os"
"path"
"path/filepath"
"sort"
"strconv"
"strings"
"testing"
Expand Down Expand Up @@ -749,6 +750,302 @@ func deleteReleaseBundleProperties(t *testing.T, lcManager *lifecycle.LifecycleS
time.Sleep(5 * time.Second)
}

func createRbIfDoesNotExists(t *testing.T, rbName, rbVersion string, lcManager *lifecycle.LifecycleServicesManager) {
isExist, err := lcManager.IsReleaseBundleExist(rbName, rbVersion, "")
assert.NoError(t, err)
if isExist {
return
}
createRbFromSpec(t, tests.LifecycleBuilds12, rbName, rbVersion, true, true)
}

func TestReleaseBundlesSearchGroups(t *testing.T) {
cleanCallback := initLifecycleTest(t, artifactoryLifecycleSetTagMinVersion)
defer cleanCallback()

lcManager := getLcServiceManager(t)

deleteBuilds := uploadBuilds(t)
defer deleteBuilds()

const rbPrefix = "my-awesome-app"
const rbNameA = rbPrefix + "-alpha"
const rbNameB = rbPrefix + "-beta"
const rbNameC = rbPrefix + "-core"
const rbNameD = "another-app"

const version1 = "1.0.0"

// Create Release Bundle A
createRbIfDoesNotExists(t, rbNameA, version1, lcManager)
defer deleteReleaseBundle(t, lcManager, rbNameA, version1)
assertStatusCompleted(t, lcManager, rbNameA, version1, "")

// Create Release Bundle B
createRbIfDoesNotExists(t, rbNameB, version1, lcManager)
defer deleteReleaseBundle(t, lcManager, rbNameB, version1)
assertStatusCompleted(t, lcManager, rbNameB, version1, "")

// Create Release Bundle C
createRbIfDoesNotExists(t, rbNameC, version1, lcManager)
defer deleteReleaseBundle(t, lcManager, rbNameC, version1)
assertStatusCompleted(t, lcManager, rbNameC, version1, "")

// Create Release Bundle D (for filter/exclusion)
createRbIfDoesNotExists(t, rbNameD, version1, lcManager)
defer deleteReleaseBundle(t, lcManager, rbNameD, version1)
assertStatusCompleted(t, lcManager, rbNameD, version1, "")

time.Sleep(3 * time.Second)

testCases := []struct {
name string
queryParams services.GetSearchOptionalQueryParams
expectedRbNames []string
expectedTotal int
expectError bool
errorMessage string
}{
{
name: "No query params - all groups, default order",
queryParams: services.GetSearchOptionalQueryParams{},
expectedRbNames: []string{rbNameD, rbNameC, rbNameB, rbNameA},
expectedTotal: 4,
expectError: false,
},
{
name: "Filter by prefix 'my-awesome-app'",
queryParams: services.GetSearchOptionalQueryParams{
FilterBy: rbPrefix + "*",
},
expectedRbNames: []string{rbNameC, rbNameB, rbNameA},
expectedTotal: 3,
expectError: false,
},
{
name: "Filter by containing 'beta'",
queryParams: services.GetSearchOptionalQueryParams{
FilterBy: rbPrefix + "-beta",
},
expectedRbNames: []string{rbNameB},
expectedTotal: 1,
expectError: false,
},
{
name: "Limit to 2 results",
queryParams: services.GetSearchOptionalQueryParams{
Limit: 2,
},
expectedTotal: 2,
expectError: false,
},
{
name: "Offset by 1, Limit to 2 results",
queryParams: services.GetSearchOptionalQueryParams{
Offset: 1,
Limit: 2,
},
expectedTotal: 2,
expectError: false,
},
{
name: "Order by name Descending",
queryParams: services.GetSearchOptionalQueryParams{
OrderBy: "created",
OrderAsc: false,
},
expectedRbNames: []string{rbNameD, rbNameC, rbNameB, rbNameA},
expectedTotal: 4,
expectError: false,
},
}

for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
resp, err := lcManager.ReleaseBundlesSearchGroup(tc.queryParams)
if tc.expectError {
assert.Error(t, err)
if tc.errorMessage != "" {
assert.Contains(t, err.Error(), tc.errorMessage)
}
return
}
assert.NoError(t, err, fmt.Sprintf("Expected no error for test case: %s", tc.name))
if tc.queryParams.FilterBy != "" {
assert.Equal(t, tc.expectedTotal, len(resp.ReleaseBundleSearchGroup), "Total count mismatch for filtered search")
} else {
assert.GreaterOrEqual(t, resp.Total, tc.expectedTotal, "Total count should be at least expected for unfiltered search")
}
var actualNames []string
for _, rb := range resp.ReleaseBundleSearchGroup {
actualNames = append(actualNames, rb.ReleaseBundleName)
}
if tc.queryParams.FilterBy != "" {
assert.Equal(t, tc.expectedRbNames, actualNames, "Release bundle names order mismatch")
} else {
assert.Subset(t, actualNames, tc.expectedRbNames, "Actual names should contain all expected names")
}
})
}
}

func TestReleaseBundlesSearchVersions(t *testing.T) {
cleanCallback := initLifecycleTest(t, artifactoryLifecycleSetTagMinVersion)
defer cleanCallback()

lcManager := getLcServiceManager(t)

deleteBuilds := uploadBuilds(t)
defer deleteBuilds()

const rbName = "my-versioned-app"
const versionA = "1.0.0"
const versionB = "1.0.1"
const versionC = "1.1.0-rc"
const versionD = "2.0.0"

createRbIfDoesNotExists(t, rbName, versionA, lcManager)
defer deleteReleaseBundle(t, lcManager, rbName, versionA)
assertStatusCompleted(t, lcManager, rbName, versionA, "")

time.Sleep(1 * time.Second)

createRbIfDoesNotExists(t, rbName, versionB, lcManager)
defer deleteReleaseBundle(t, lcManager, rbName, versionB)
assertStatusCompleted(t, lcManager, rbName, versionB, "")

time.Sleep(1 * time.Second)

createRbIfDoesNotExists(t, rbName, versionC, lcManager)
defer deleteReleaseBundle(t, lcManager, rbName, versionC)
assertStatusCompleted(t, lcManager, rbName, versionC, "")

time.Sleep(1 * time.Second)

createRbIfDoesNotExists(t, rbName, versionD, lcManager)
defer deleteReleaseBundle(t, lcManager, rbName, versionD)
assertStatusCompleted(t, lcManager, rbName, versionD, "")

log.Info("Created four versions for release bundle '%s' for search testing.", rbName)
time.Sleep(3 * time.Second)

testCases := []struct {
name string
releaseBundleName string
queryParams services.GetSearchOptionalQueryParams
expectedRbVersions []string
expectedTotal int
expectError bool
errorMessage string
}{
{
name: "No query params - all versions, default order",
releaseBundleName: rbName,
queryParams: services.GetSearchOptionalQueryParams{},
expectedRbVersions: []string{versionA, versionB, versionC, versionD},
expectedTotal: 4,
expectError: false,
},
{
name: "Filter by prefix '1.0'",
releaseBundleName: rbName,
queryParams: services.GetSearchOptionalQueryParams{
FilterBy: "1.0*",
},
expectedRbVersions: []string{versionA, versionB},
expectedTotal: 2,
expectError: false,
},
{
name: "Filter by containing 'rc'",
releaseBundleName: rbName,
queryParams: services.GetSearchOptionalQueryParams{
FilterBy: "1.1.0-rc*",
},
expectedRbVersions: []string{versionC},
expectedTotal: 1,
expectError: false,
},
{
name: "Limit to 2 results, ordered by version ascending",
releaseBundleName: rbName,
queryParams: services.GetSearchOptionalQueryParams{
Limit: 2,
OrderBy: "release_bundle_version",
OrderAsc: true,
},
expectedRbVersions: []string{versionA, versionB},
expectedTotal: 2,
expectError: false,
},
{
name: "Offset by 2, Limit 1, ordered by version descending",
releaseBundleName: rbName,
queryParams: services.GetSearchOptionalQueryParams{
Offset: 2,
Limit: 1,
OrderBy: "release_bundle_version",
OrderAsc: false,
},
expectedRbVersions: []string{versionB},
expectedTotal: 1,
expectError: false,
},
{
name: "Order by version Descending",
releaseBundleName: rbName,
queryParams: services.GetSearchOptionalQueryParams{
OrderBy: "release_bundle_version",
OrderAsc: false,
},
expectedRbVersions: []string{versionD, versionC, versionB, versionA},
expectedTotal: 4,
expectError: false,
},
{
name: "Order by created Ascending",
releaseBundleName: rbName,
queryParams: services.GetSearchOptionalQueryParams{
OrderBy: "created",
OrderAsc: true,
},
expectedRbVersions: []string{versionA, versionC, versionB, versionD},
expectedTotal: 4,
expectError: false,
},
}

for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
var resp services.ReleaseBundleVersionsResponse
var err error
resp, err = lcManager.ReleaseBundlesSearchVersions(tc.releaseBundleName, tc.queryParams)
if tc.expectError {
assert.Error(t, err)
if tc.errorMessage != "" {
assert.Contains(t, err.Error(), tc.errorMessage)
}
return
}
if tc.queryParams.FilterBy != "" {
assert.Equal(t, tc.expectedTotal, len(resp.ReleaseBundles), "Total count mismatch for filtered search")
} else {
assert.GreaterOrEqual(t, resp.Total, tc.expectedTotal, "Total count should be at least expected for unfiltered search")
}
var actualVersions []string
for _, rb := range resp.ReleaseBundles {
actualVersions = append(actualVersions, rb.ReleaseBundleVersion)
}
if tc.queryParams.FilterBy != "" {
sort.Strings(actualVersions)
assert.Equal(t, tc.expectedRbVersions, actualVersions, "Release bundle versions order mismatch")
} else {
assert.Subset(t, actualVersions, tc.expectedRbVersions, "Actual names should contain all expected names")
}
})
}
}

func setReleaseBundleTag(t *testing.T, lcManager *lifecycle.LifecycleServicesManager, rbName, rbVersion,
projectKey, tag string,
) {
Expand Down
Loading