Support pnpm command by fluxxBot · Pull Request #393 · jfrog/jfrog-cli-artifactory

fluxxBot · 2026-03-11T12:59:56Z

All tests passed. If this feature is not already covered by the tests, I added new tests.
All static analysis checks passed.
Appropriate label is added to auto generate release notes.
I used gofmt for formatting the code before submitting the pull request.
PR description is clear and concise, and it includes the proposed solution/fix.

Description:
Support pnpm command for jfrog cli

Depends on:

Support pnpm command for jfrog-cli jfrog-cli#3390

agrasth · 2026-03-16T08:03:15Z

+// resolveAqlRepo determines the correct repo to use for AQL queries.
+// Remote repos store files in a "<repo>-cache" local repo, so AQL must target that.
+// Virtual and local repos are used as-is.
+func resolveAqlRepo(repo string, servicesManager artifactory.ArtifactoryServicesManager) string {


Each unique registry repo triggers a GetRepository API call. If the same repo appears in multiple batches, it's queried repeatedly.
Is that possible to cache the result in a map[string]string at the call site in batchedAQLFetch

we only call resolveAqlRepo once per distinct repo when building batches. this unique repo is found just before this workflow

agrasth · 2026-03-16T08:05:05Z

+
+	if pic.collectBuildInfo {
+		if err = pic.collectAndSaveBuildInfo(); err != nil {
+			log.Warn("pnpm install completed successfully, but build info collection failed:", err.Error())


When collectAndSaveBuildInfo fails, the error is logged as a warning and nil is returned.
Should we consider surface the failure via log.Warn with a note about how to re-collect, or consider adding a --strict-build-info flag that makes this a hard failure.
WDYT?

command at the moment is fail safe, we are not failing the original command incase the build-info collection fails, we can have a flag accross all package manager that will revert this operation if required

bhanurp · 2026-03-31T05:31:49Z

+}
+
+func runPnpmLs(workingDir string) ([]pnpmLsProject, error) {
+	pnpmLsArgs := []string{"ls", "-r", "--depth", "Infinity", "--json"}


--json is already there, I am talking about --long, without long flag is it omitting resolved packages?

fluxxBot requested a review from a team March 11, 2026 12:59

fluxxBot added the new feature Automatically generated release notes label Mar 11, 2026

fluxxBot had a problem deploying to frogbot March 11, 2026 13:00 — with GitHub Actions Failure

fluxxBot removed the request for review from a team March 11, 2026 13:00

fluxxBot force-pushed the RTECO-935 branch from d373179 to 11e08da Compare March 11, 2026 13:04

fluxxBot had a problem deploying to frogbot March 11, 2026 13:04 — with GitHub Actions Failure

fluxxBot mentioned this pull request Mar 11, 2026

Support pnpm command for jfrog-cli jfrog/jfrog-cli#3390

Merged

3 of 4 tasks

reshmifrog added the safe to test Approve running integration tests on a pull request label Mar 12, 2026

github-actions Bot removed the safe to test Approve running integration tests on a pull request label Mar 12, 2026

fluxxBot had a problem deploying to frogbot March 13, 2026 17:15 — with GitHub Actions Failure

Support pnpm command

a3fe954

fluxxBot force-pushed the RTECO-935 branch from 067d499 to c4ff104 Compare March 13, 2026 17:21

fluxxBot had a problem deploying to frogbot March 13, 2026 17:21 — with GitHub Actions Failure

validations and tests

91a2f81

fluxxBot force-pushed the RTECO-935 branch from c4ff104 to 91a2f81 Compare March 13, 2026 17:27

fluxxBot had a problem deploying to frogbot March 13, 2026 17:27 — with GitHub Actions Failure

fixed artifacts details and tests

0c6cf28

fluxxBot had a problem deploying to frogbot March 13, 2026 19:34 — with GitHub Actions Failure

version support

ba93453

fluxxBot had a problem deploying to frogbot March 13, 2026 19:53 — with GitHub Actions Failure

agrasth reviewed Mar 16, 2026

View reviewed changes

Merge branch 'main' into RTECO-935

11ea0e3

reshmifrog had a problem deploying to frogbot March 16, 2026 08:31 — with GitHub Actions Failure

bhanurp requested review from a team, agrasth, bhanurp, itsmeleela, naveenku-jfrog and reshmifrog and removed request for a team March 16, 2026 08:43

fixed bughunt related code and comments

765e163

fluxxBot had a problem deploying to frogbot March 24, 2026 11:22 — with GitHub Actions Failure

stream logs to console

557dfd1

fluxxBot had a problem deploying to frogbot March 24, 2026 11:51 — with GitHub Actions Failure

fixed test

6276282

fluxxBot had a problem deploying to frogbot March 24, 2026 12:05 — with GitHub Actions Failure

fluxxBot requested review from agrasth and bhanurp March 24, 2026 14:19

agrasth approved these changes Mar 25, 2026

View reviewed changes

bhanurp reviewed Mar 30, 2026

View reviewed changes

fixed comments

8ef3062

fluxxBot had a problem deploying to frogbot March 30, 2026 11:46 — with GitHub Actions Failure

fluxxBot added the safe to test Approve running integration tests on a pull request label Mar 30, 2026

fluxxBot requested a review from bhanurp March 30, 2026 11:46

github-actions Bot removed the safe to test Approve running integration tests on a pull request label Mar 30, 2026

Merge branch 'main' into RTECO-935

a65949c

fluxxBot had a problem deploying to frogbot March 30, 2026 11:47 — with GitHub Actions Failure

fluxxBot added the safe to test Approve running integration tests on a pull request label Mar 30, 2026

github-actions Bot removed the safe to test Approve running integration tests on a pull request label Mar 30, 2026

fixed tests

547b269

fluxxBot had a problem deploying to frogbot March 30, 2026 12:18 — with GitHub Actions Failure

fluxxBot added the safe to test Approve running integration tests on a pull request label Mar 30, 2026

github-actions Bot removed the safe to test Approve running integration tests on a pull request label Mar 30, 2026

bhanurp approved these changes Mar 31, 2026

View reviewed changes

fixed evidence test

48a54e8

fluxxBot had a problem deploying to frogbot March 31, 2026 09:31 — with GitHub Actions Failure

fluxxBot merged commit 0deeb49 into main Mar 31, 2026
24 of 25 checks passed

fluxxBot deleted the RTECO-935 branch March 31, 2026 09:48

BrewTestBot mentioned this pull request Apr 1, 2026

jfrog-cli 2.98.0 Homebrew/homebrew-core#275598

Merged

blinkagent Bot mentioned this pull request Aug 24, 2026

Add pnpm support to JFrog modules (jfrog-token, jfrog-oauth) coder/registry#1074

Closed

Navigation Menu

Repository navigation

Support pnpm command - #393

Support pnpm command#393
fluxxBot merged 15 commits into
mainfrom
RTECO-935

fluxxBot commented Mar 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

agrasth Mar 16, 2026

Uh oh!

fluxxBot Mar 16, 2026

Uh oh!

agrasth Mar 16, 2026

Uh oh!

fluxxBot Mar 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bhanurp Mar 31, 2026

Uh oh!

Uh oh!

This branch had an error being deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

fluxxBot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

agrasth Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

fluxxBot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

agrasth Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

fluxxBot Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bhanurp Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch had an error being deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fluxxBot commented Mar 11, 2026 •

edited

Loading