Skip to content

Support nested path for docker build - #354

Merged
bhanurp merged 3 commits into
jfrog:mainfrom
fluxxBot:dockernested
Feb 6, 2026
Merged

bhanurp merged 3 commits into
jfrog:mainfrom
fluxxBot:dockernested

Conversation

@fluxxBot

@fluxxBot fluxxBot commented Jan 29, 2026 •

Copy link
Copy Markdown
Contributor
  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • Appropriate label is added to auto generate release notes.
  • I used gofmt for formatting the code before submitting the pull request.
  • PR description is clear and concise, and it includes the proposed solution/fix.

Description:
It was found that uploading docker images inside a nested path caused failure in attaching build properties in the artifacts due to invalid path construction:
eg: docker-repo/myorg/image:latest when uploaded, cli tried to attach properties on docker-repo/image:latest, as a result attaching properties caused 404 not found failure.

Solution:
instead of using image full name which returned image:latest, we are using image full name without repo which returns myorg/image:latest

depends on:

  1. Support nested path for docker build jfrog-cli#3330

@fluxxBot
fluxxBot requested a review from bhanurp January 29, 2026 12:46
@fluxxBot fluxxBot added the improvement Automatically generated release notes label Jan 29, 2026
// e.g., "docker-local/myorg/hello-world:latest" -> "myorg/hello-world"
// e.g., "docker-local/hello-world:latest" -> "hello-world"
// e.g., "docker-local/myorg/hello-world@sha256:12334" -> "myorg/hello-world"
func (image *Image) GetImageLongNameWithoutRepoWithoutTag() (string, error) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func (image *Image) GetImageLongNameWithoutRepoWithoutTag() (string, error) {
func (image *Image) GetImageLongNameWithoutRepoAndTag() (string, error) {

// GetImageLongNameWithoutRepoWithoutTag removes the registry hostname and repository name, returning the organization and image name.
// e.g., "docker-local/myorg/hello-world:latest" -> "myorg/hello-world"
// e.g., "docker-local/hello-world:latest" -> "hello-world"
// e.g., "docker-local/myorg/hello-world@sha256:12334" -> "myorg/hello-world"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//@sha256:
is this pattern handled

@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 6, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Feb 6, 2026
@github-actions

github-actions Bot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@bhanurp
bhanurp merged commit 7a05b41 into jfrog:main Feb 6, 2026
48 of 49 checks passed

This branch was previously deployed

1 inactive deployment
frogbot — deeed1ab Deployed Feb 6, 2026 by bhanurp via scan-pull-request #711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants