Skip to content

Added capability to support docker pull with image sha - #323

Merged
fluxxBot merged 5 commits into
jfrog:mainfrom
fluxxBot:dockerShaPull
Dec 22, 2025
Merged

fluxxBot merged 5 commits into
jfrog:mainfrom
fluxxBot:dockerShaPull

Conversation

@fluxxBot

@fluxxBot fluxxBot commented Dec 12, 2025 •

Copy link
Copy Markdown
Contributor
  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • Appropriate label is added to auto generate release notes.
  • I used gofmt for formatting the code before submitting the pull request.
  • PR description is clear and concise, and it includes the proposed solution/fix.

Description:
Added support for collecting build info for sha based image resolution from artifactory, for example:
docker command -> jf docker pull <registry>/<namespace>/<image>@sha:xyz --build-name <build-name> --build-number <build-number>

depends on:

  1. Added capability to support docker pull with image sha jfrog-cli#3273

@fluxxBot
fluxxBot requested a review from bhanurp December 12, 2025 15:01
@fluxxBot fluxxBot added the new feature Automatically generated release notes label Dec 12, 2025
}

// Returns the physical Artifactory repository name of the pulled/pushed image, by reading a response header from Artifactory.
func (image *Image) GetRemoteRepoAndManifestTypeAndLeadSha(serviceManager artifactory.ArtifactoryServicesManager) (string, string, string, error) {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this function since a problem was identified where response was missing headers X-Artifactory-Filename

@fluxxBot fluxxBot changed the title Add capability to support docker pull with image sha Added capability to support docker pull with image sha Dec 12, 2025
@fluxxBot
fluxxBot requested a review from itsmeleela December 12, 2025 15:29

@bhanurp bhanurp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets retry running go fmt some imports are not grouped properly

@fluxxBot
fluxxBot merged commit 20b9565 into jfrog:main Dec 22, 2025
10 of 11 checks passed

This branch had an error being deployed

1 failed deployment
frogbot — a7a1c84d Deployed Dec 22, 2025 by fluxxBot via scan-pull-request #588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants