Repository navigation
[sse] Preserve data beginning with a colon - #597
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
Summary
data: :hello\n\ncurrently decodes to an event with nil data. The encoder can emit this payload, so text round trips lose it too.Parse every dispatched data buffer. Actual comment lines are already skipped before field parsing.
The tests cover both separator forms, a lone colon, multiline data with comments and metadata, consecutive events, and text round trips.
How was it tested?
All eight new regression cases fail with the original decoder.
go test -race -cover -v ./sse/...passes on Go 1.27.1 with 94.5% library coverage.The SSE suite also passes on Go 1.24.2 with 94.4% coverage.
Configured
golangci-lint runandgolangci-lint fmt --diffpass for the SSE module. Vet and example builds pass.I ran the monorepo plugin's Go commands across all seven workspace modules on Go 1.27.1.
The race suite passes all 1,703 test and subtest markers with one existing skip. All module builds pass.
The full formatter and lint runners stop at three formatting findings in unchanged
envsec/pkg/envclifiles.Both runners produce identical findings on untouched
mainwith the same tooling.Community Contribution License
All community contributions in this pull request are licensed to the project maintainers under the terms of the Apache 2 License.
I represent that I have the right to license these contributions to the project maintainers under the Apache 2 License.
This follows the Community Contribution License.