Skip to content

[P3][testing] Failed-update integration test can pass when the command is broken #39

Description

@jdevera

Summary

The failed-update integration test verifies that the original package still works by checking whether combined stdout/stderr contains the word bonjour. Error output such as an unknown-command message can include the invoked command name and satisfy that assertion.

Affected code

  • test/integration/test-failed-update-pause.sh:137

Impact

A regression that removes or breaks the original command after a failed update can still produce a green integration test, weakening the rollback/pause safety net.

Suggested correction

Assert the command exit status and an output value unique to the known version-1.0.0 implementation. Keep diagnostic stderr separate from the functional output when practical.

Acceptance criteria

  • The test fails when the command is missing, exits non-zero, or runs the wrong version.
  • The test passes only for the expected version-1.0.0 behavior.
  • A negative test or fixture demonstrates that an unknown-command message cannot satisfy the oracle.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingpriority: lowP3: cleanup or documentationtestingTest coverage or correctness issueupstreamAlso affects the upstream project

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions