Repository navigation
Fix WebMCP topic reads on preview deployments - #262
Merged
Merged
Conversation
The manifest's mdUrl was absolute (site.url), so on Cloudflare Pages preview deployments get_topic fetched the production Markdown instead of the preview's — blocked by the site's connect-src 'self' CSP. Make mdUrl root-relative; the canonical url stays absolute. Adds the same per-origin regression test as specification.email.
Deploying specification-website with
|
| Latest commit: |
3ede509
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7d16450a.specification-website.pages.dev |
| Branch Preview URL: | https://webmcp-relative-mdurl.specification-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same bug Joost fixed on specification.email (PR #3, commit 32d0006), present here too: the manifest's
mdUrlwas absolute (site.url), so on Cloudflare Pages preview deploymentsget_topicfetched the production Markdown instead of the preview's — blocked by this site'sconnect-src 'self'CSP.Makes
mdUrlroot-relative; the canonicalurlstays absolute. Adds the same per-origin regression test (preview.example.pages.dev+ local dev) toscripts/test-webmcp.mjs.Verified: full build +
check-integritypass,test:webmcp7/7, eslint clean (0 errors), Prettier clean.