Drop UncheckedNoSuchAlgorithmException#60
Merged
Conversation
jchambers
force-pushed
the
checked_no_such_algorithm_exception
branch
from
f309546 to
c343b63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially rolls back the changes from #29. Introducing an unchecked version of
NoSuchAlgorithmExceptionhelped in some ways, but muddied the waters in others. After this change, we simply don't throw exceptions at all in cases where callers are specifying an algorithm that the JRE must support, but may throw a checkedNoSuchAlgorithmExceptionin cases where the algorithm legitimately might not be supported.I think/hope this still grants the ergonomic benefits we hoped to achieve in #29 while being a little more correct.
It also bears mentioning that this would be a lot easier under Java 25 with flexible constructor bodies, but I don't think this change justifies a very large jump in minimum supported Java version.