Convert the IA* field wrappers from classes to structs (2.0) - #77
Draft
jbuckner wants to merge 1 commit into
Draft
Convert the IA* field wrappers from classes to structs (2.0)#77jbuckner wants to merge 1 commit into
jbuckner wants to merge 1 commit into
Conversation
Every decoded field cost a heap allocation as a class; structs drop that. Breaking for anyone subclassing the wrappers, so this waits for 2.0. Closes #54 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015u2FT1T8yYQsEztyKg6UGf
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
=======================================
Coverage 91.98% 91.98%
=======================================
Files 13 13
Lines 686 686
=======================================
Hits 631 631
Misses 55 55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54. Draft: breaking, holds for a 2.0 window, and will need a rebase after the 1.x ModelFieldTypes fixes (#61, #66) merge. Pairs with #29.
🤖 Generated with Claude Code
https://claude.ai/code/session_015u2FT1T8yYQsEztyKg6UGf