Repository navigation
Replace ImageMagick with Chrome - #4
Merged
Merged
Conversation
Render screenshot contact sheets with the existing Chrome DevTools harness and remove ImageMagick setup from scripts, CI, and docs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The caller does not await the now-async buildSheet(), so its assertion always passes on the Promise and rendering failures bypass main()’s error handler.
1 open issue
What changed in this PR
This PR replaces ImageMagick contact-sheet generation with Chrome/Chromium through the existing DevTools harness, removing a separate system dependency from the screenshot workflow.
Changes:
- Render contact sheets in the browser with sorted images, filename labels, and four-column layout.
- Remove ImageMagick discovery, preflight checks, and CI installation steps.
- Update screenshot tests and local setup documentation.
| File | Description |
|---|---|
tests/shot-sheet.test.mjs |
Update command fixtures and test generated sheet markup. |
tests/platform-tools.test.mjs |
Remove ImageMagick discovery tests. |
scripts/tools.mjs |
Delete ImageMagick discovery and execution helpers. |
scripts/shot.mjs |
Remove the ImageMagick preflight requirement. |
scripts/shot-sheet.mjs |
Compose and capture contact sheets using Chrome. |
README.md |
Remove ImageMagick from verification prerequisites. |
docs/code.md |
Simplify local setup to require only a browser. |
.github/workflows/windows-verify.yml |
Remove ImageMagick installation on Windows. |
.github/workflows/copilot-setup-steps.yml |
Remove ImageMagick setup and version checks. |
.github/workflows/ci.yml |
Remove ImageMagick and associated font installation. |
Review effort: Balanced
Wait for the asynchronous sheet builder before asserting its result so screenshot failures reach the main error handler. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N/A
What changed
Why
ImageMagick duplicated image-processing functionality that Chrome already provides for screenshot generation, adding a separate system dependency across local environments and CI.
Checklist
npm run verifypassesScreenshots
The contact sheet and individual screenshots are in the web-screenshots artifact from the successful CI run. Download the artifact and open
contact-sheet.pngto view the generated sheet.